From: Yury Norov <yury.norov@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andrea Righi <arighi@nvidia.com>,
David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Joel Fernandes <joelagnelf@nvidia.com>, Ian May <ianm@nvidia.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH sched_ext/for-6.15] sched_ext: idle: Introduce node-aware idle cpu kfunc helpers
Date: Tue, 18 Feb 2025 14:09:41 -0500 [thread overview]
Message-ID: <Z7Ta9ULl141jcjFF@thinkpad> (raw)
In-Reply-To: <Z7TZIvaxzEDD2u9A@slm.duckdns.org>
On Tue, Feb 18, 2025 at 09:01:54AM -1000, Tejun Heo wrote:
> On Tue, Feb 18, 2025 at 07:04:41PM +0100, Andrea Righi wrote:
> > Introduce a new kfunc to retrieve the node associated to a CPU:
> >
> > int scx_bpf_cpu_node(s32 cpu)
> >
> > Add the following kfuncs to provide BPF schedulers direct access to
> > per-node idle cpumasks information:
> >
> > const struct cpumask *scx_bpf_get_idle_cpumask_node(int node)
> > const struct cpumask *scx_bpf_get_idle_smtmask_node(int node)
> > s32 scx_bpf_pick_idle_cpu_node(const cpumask_t *cpus_allowed,
> > int node, u64 flags)
> > s32 scx_bpf_pick_any_cpu_node(const cpumask_t *cpus_allowed,
> > int node, u64 flags)
> >
> > Moreover, trigger an scx error when any of the non-node aware idle CPU
> > kfuncs are used when SCX_OPS_BUILTIN_IDLE_PER_NODE is enabled.
> >
> > Cc: Yury Norov [NVIDIA] <yury.norov@gmail.com>
> > Signed-off-by: Andrea Righi <arighi@nvidia.com>
>
> Applied to sched_ext/for-6.15.
I added my review-by in v12. Can you please add it here?
Reviewed-by: Yury Norov [NVIDIA] <yury.norov@gmail.com>
next prev parent reply other threads:[~2025-02-18 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 18:04 [PATCH sched_ext/for-6.15] sched_ext: idle: Introduce node-aware idle cpu kfunc helpers Andrea Righi
2025-02-18 19:01 ` Tejun Heo
2025-02-18 19:09 ` Yury Norov [this message]
2025-02-18 19:11 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7Ta9ULl141jcjFF@thinkpad \
--to=yury.norov@gmail.com \
--cc=arighi@nvidia.com \
--cc=bpf@vger.kernel.org \
--cc=changwoo@igalia.com \
--cc=ianm@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox