From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Christian Brauner <brauner@kernel.org>
Cc: NeilBrown <neilb@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the vfs-brauner tree
Date: Wed, 19 Feb 2025 15:45:41 +0700 [thread overview]
Message-ID: <Z7WaNWHRkqt2rFGA@archie.me> (raw)
In-Reply-To: <20250219153444.0046e433@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
On Wed, Feb 19, 2025 at 03:34:44PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/filesystems/porting.rst:1173: ERROR: Unexpected indentation. [docutils]
>
> Introduced by commit
>
> 20c2c1baa9ab ("VFS: add common error checks to lookup_one_qstr_excl()")
>
Separating the bullet list should suffice (plus s/recommend/recommended/
for consistency with the rest of docs):
---- >8 ----
diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst
index 3b6622fbd66be9..cfac50a7258db6 100644
--- a/Documentation/filesystems/porting.rst
+++ b/Documentation/filesystems/porting.rst
@@ -1166,10 +1166,11 @@ kern_path_locked() and user_path_locked() no longer return a negative
dentry so this doesn't need to be checked. If the name cannot be found,
ERR_PTR(-ENOENT) is returned.
-** recommend**
+** recommended**
lookup_one_qstr_excl() is changed to return errors in more cases, so
-these conditions don't require explicit checks.
+these conditions don't require explicit checks:
+
- if LOOKUP_CREATE is NOT given, then the dentry won't be negative,
ERR_PTR(-ENOENT) is returned instead
- if LOOKUP_EXCL IS given, then the dentry won't be positive,
Let me know if I should send the formal patch.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-02-19 8:45 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 4:34 linux-next: build warning after merge of the vfs-brauner tree Stephen Rothwell
2025-02-19 8:45 ` Bagas Sanjaya [this message]
2025-02-19 10:04 ` Christian Brauner
2025-02-19 11:23 ` Bagas Sanjaya
2025-02-19 21:12 ` NeilBrown
-- strict thread matches above, loose matches on Subject: below --
2025-06-17 5:12 Stephen Rothwell
2025-08-01 4:38 ` Stephen Rothwell
2025-08-04 12:33 ` Christian Brauner
2025-02-28 7:55 Stephen Rothwell
2025-02-28 10:37 ` Christian Brauner
2024-10-30 5:24 Stephen Rothwell
2024-10-01 3:39 Stephen Rothwell
2024-10-01 15:05 ` Christian Brauner
2024-09-30 23:11 Stephen Rothwell
2024-10-01 4:19 ` Stephen Rothwell
2024-10-01 15:00 ` Christian Brauner
2024-10-07 22:58 ` Stephen Rothwell
2024-09-06 8:29 Stephen Rothwell
2024-09-18 5:24 ` Stephen Rothwell
2024-10-02 22:45 ` Stephen Rothwell
2024-10-03 9:11 ` Christian Brauner
2024-08-29 6:19 Stephen Rothwell
2024-08-26 6:01 Stephen Rothwell
2024-08-26 16:00 ` Pankaj Raghav (Samsung)
2024-08-13 3:40 Stephen Rothwell
2024-08-28 5:22 ` Stephen Rothwell
2024-08-01 5:55 Stephen Rothwell
2024-08-01 5:56 ` Stephen Rothwell
2024-08-01 5:01 Stephen Rothwell
2024-08-01 13:21 ` David Howells
2024-08-01 13:41 ` Christian Brauner
2024-05-28 0:49 Stephen Rothwell
2024-05-28 3:31 ` Stephen Rothwell
2024-05-28 12:30 ` Christian Brauner
2024-05-28 12:39 ` Arnd Bergmann
2024-03-05 23:51 Stephen Rothwell
2024-03-06 2:48 ` Linus Torvalds
2024-03-06 4:37 ` Stephen Rothwell
2024-03-06 4:47 ` Linus Torvalds
2024-03-06 9:55 ` Christian Brauner
2024-03-06 4:58 ` Stephen Rothwell
2024-01-17 2:39 Stephen Rothwell
2023-12-21 7:48 Stephen Rothwell
2023-12-21 13:19 ` David Howells
2023-11-24 2:13 Stephen Rothwell
2023-11-24 7:58 ` Amir Goldstein
2023-09-25 4:31 Stephen Rothwell
2023-08-15 11:15 Stephen Rothwell
2023-08-07 5:38 Stephen Rothwell
2023-07-31 3:58 Stephen Rothwell
2023-07-04 3:51 Stephen Rothwell
2023-05-24 3:46 Stephen Rothwell
2023-05-24 9:06 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7WaNWHRkqt2rFGA@archie.me \
--to=bagasdotme@gmail.com \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=neilb@suse.de \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).