From: Johan Hovold <johan@kernel.org>
To: Stephan Gerhold <stephan.gerhold@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Abel Vesa <abel.vesa@linaro.org>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Akhil P Oommen <quic_akhilpo@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH 4/4] arm64: dts: qcom: x1e80100: Drop unused passive thermal trip points for CPU
Date: Wed, 19 Feb 2025 16:47:48 +0100 [thread overview]
Message-ID: <Z7X9JIDVMorYGuS1@hovoldconsulting.com> (raw)
In-Reply-To: <20250219-x1e80100-thermal-fixes-v1-4-d110e44ac3f9@linaro.org>
On Wed, Feb 19, 2025 at 12:36:21PM +0100, Stephan Gerhold wrote:
> There are currently two passive trip points defined for the CPU, but no
> cooling devices are attached to the thermal zones. We don't have support
> for cpufreq upstream yet, but actually this is redundant anyway because the
> CPU is throttled automatically when reaching high temperatures.
>
> Drop the passive trip points and keep just the critical shutdown as safety
> measure in case the throttling fails.
>
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Looks good. Perhaps we should backport this one as well in case the
current passive trip points cause unnecessary work to done for no
reason.
Either way:
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Johan
next prev parent reply other threads:[~2025-02-19 15:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 11:36 [PATCH 0/4] arm64: dts: qcom: x1e80100: Fix thermal trip points Stephan Gerhold
2025-02-19 11:36 ` [PATCH 1/4] arm64: dts: qcom: x1e80100: Fix video thermal zone Stephan Gerhold
2025-02-19 15:28 ` Johan Hovold
2025-02-19 16:22 ` Stephan Gerhold
2025-02-20 12:54 ` Konrad Dybcio
2025-02-19 11:36 ` [PATCH 2/4] arm64: dts: qcom: x1e80100: Apply consistent critical thermal shutdown Stephan Gerhold
2025-02-19 15:36 ` Johan Hovold
2025-02-19 16:28 ` Stephan Gerhold
2025-02-20 12:55 ` Konrad Dybcio
2025-02-19 11:36 ` [PATCH 3/4] arm64: dts: qcom: x1e80100: Add GPU cooling Stephan Gerhold
2025-02-19 15:42 ` Johan Hovold
2025-02-21 19:35 ` Konrad Dybcio
2025-02-19 11:36 ` [PATCH 4/4] arm64: dts: qcom: x1e80100: Drop unused passive thermal trip points for CPU Stephan Gerhold
2025-02-19 15:47 ` Johan Hovold [this message]
2025-02-21 19:36 ` Konrad Dybcio
2025-03-04 17:00 ` [PATCH 0/4] arm64: dts: qcom: x1e80100: Fix thermal trip points Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7X9JIDVMorYGuS1@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_akhilpo@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=robh@kernel.org \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox