From: Alison Schofield <alison.schofield@intel.com>
To: Li Ming <ming.li@zohomail.com>
Cc: dave@stgolabs.net, jonathan.cameron@huawei.com,
dave.jiang@intel.com, vishal.l.verma@intel.com,
ira.weiny@intel.com, dan.j.williams@intel.com,
linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] cxl/core: cxl_mem_sanitize() cleanup
Date: Wed, 19 Feb 2025 09:34:05 -0800 [thread overview]
Message-ID: <Z7YWDfB5iOSeVd1C@aschofie-mobl2.lan> (raw)
In-Reply-To: <20250217144828.30651-3-ming.li@zohomail.com>
On Mon, Feb 17, 2025 at 10:48:23PM +0800, Li Ming wrote:
> In cxl_mem_sanitize(), the down_read() and up_read() for
> cxl_region_rwsem can be simply replaced by a guard(rwsem_read), and the
> local variable 'rc' can be removed.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Signed-off-by: Li Ming <ming.li@zohomail.com>
> ---
> drivers/cxl/core/mbox.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
snip
next prev parent reply other threads:[~2025-02-19 18:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 14:48 [PATCH v2 0/7] Use guard() instead of rwsem locking Li Ming
2025-02-17 14:48 ` [PATCH v2 1/7] cxl/core: Use guard() to replace open-coded down_read/write() Li Ming
2025-02-19 17:11 ` Dave Jiang
2025-02-19 17:33 ` Alison Schofield
2025-02-17 14:48 ` [PATCH v2 2/7] cxl/core: cxl_mem_sanitize() cleanup Li Ming
2025-02-19 17:12 ` Dave Jiang
2025-02-19 17:34 ` Alison Schofield [this message]
2025-02-17 14:48 ` [PATCH v2 3/7] cxl/memdev: cxl_memdev_ioctl() cleanup Li Ming
2025-02-19 17:16 ` Dave Jiang
2025-02-19 17:35 ` Alison Schofield
2025-02-17 14:48 ` [PATCH v2 4/7] cxl/core: Use guard() to drop the goto pattern of cxl_dpa_free() Li Ming
2025-02-19 17:19 ` Dave Jiang
2025-02-19 17:36 ` Alison Schofield
2025-02-17 14:48 ` [PATCH v2 5/7] cxl/core: Use guard() to drop goto pattern of cxl_dpa_alloc() Li Ming
2025-02-19 17:21 ` Dave Jiang
2025-02-19 17:36 ` Alison Schofield
2025-02-20 1:01 ` Dan Williams
2025-02-20 1:26 ` Li Ming
2025-02-20 1:29 ` Dan Williams
2025-02-17 14:48 ` [PATCH v2 6/7] cxl/region: Drop goto pattern in cxl_dax_region_alloc() Li Ming
2025-02-19 17:23 ` Dave Jiang
2025-02-19 17:37 ` Alison Schofield
2025-02-17 14:48 ` [PATCH v2 7/7] cxl/region: Drop goto pattern of construct_region() Li Ming
2025-02-18 17:24 ` Jonathan Cameron
2025-02-19 17:24 ` Dave Jiang
2025-02-19 17:38 ` Alison Schofield
2025-02-20 1:04 ` Dan Williams
2025-02-20 1:42 ` Li Ming
2025-02-18 17:54 ` [PATCH v2 0/7] Use guard() instead of rwsem locking Davidlohr Bueso
2025-02-19 20:46 ` Ira Weiny
2025-02-19 21:09 ` Dave Jiang
2025-02-20 0:43 ` Li Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7YWDfB5iOSeVd1C@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.li@zohomail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox