From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] auxdisplay: MAX6959 should select BITREVERSE
Date: Thu, 20 Feb 2025 14:44:25 +0200 [thread overview]
Message-ID: <Z7cjqd4T5vsELuoK@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdXxu_H52JJPwwU-GSNA=J0qQ8oJtU53+gEidukTaFhseg@mail.gmail.com>
On Thu, Feb 20, 2025 at 10:07:52AM +0100, Geert Uytterhoeven wrote:
> Hi Andy,
>
> On Thu, 20 Feb 2025 at 09:21, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Thu, Feb 20, 2025 at 9:48 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > >
> > > If CONFIG_BITREVERSE is not enabled:
> > >
> > > max6959.c:(.text+0x92): undefined reference to `byte_rev_table'
> >
> > LGTM now, thanks.
> > Do you think we are in an emergency to send it for v6.14?
>
> No.
>
> > If possible, I would prefer to send this in PR for v6.15 as the
> > problem was from day 1 and only bitbot found the configuration so far
> > that fails to build.
>
> I had to go through lots of loops to disable BITREVERSE and reproduce
> the build issue (e.g. CRC32 selects BITREVERSE), so I doubt anyone
> will ever encounter it with a real config.
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-02-20 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 7:48 [PATCH v2] auxdisplay: MAX6959 should select BITREVERSE Geert Uytterhoeven
2025-02-20 8:21 ` Andy Shevchenko
2025-02-20 9:07 ` Geert Uytterhoeven
2025-02-20 12:44 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7cjqd4T5vsELuoK@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox