[PATCH v2] auxdisplay: MAX6959 should select BITREVERSE

[PATCH v2] auxdisplay: MAX6959 should select BITREVERSE

[Geert Uytterhoeven]

If CONFIG_BITREVERSE is not enabled:

    max6959.c:(.text+0x92): undefined reference to `byte_rev_table'

Fixes: a9bcd02fa42217c7 ("auxdisplay: Add driver for MAX695x 7-segment LED controllers")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/202502161703.3Vr4M7qg-lkp@intel.com/
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
v2:
  - Do not sort selects.
---
 drivers/auxdisplay/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index 8934e6ad5772b4e0..3b588318e8b5700b 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -505,6 +505,7 @@ config MAX6959
 	depends on I2C
 	select REGMAP_I2C
 	select LINEDISP
+	select BITREVERSE
 	help
 	  If you say yes here you get support for the following Maxim chips
 	  (I2C 7-segment LED display controller):
-- 
2.43.0

Re: [PATCH v2] auxdisplay: MAX6959 should select BITREVERSE

[Andy Shevchenko]

On Thu, Feb 20, 2025 at 9:48 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> If CONFIG_BITREVERSE is not enabled:
>
>     max6959.c:(.text+0x92): undefined reference to `byte_rev_table'

LGTM now, thanks.
Do you think we are in an emergency to send it for v6.14?
If possible, I would prefer to send this in PR for v6.15 as the
problem was from day 1 and only bitbot found the configuration so far
that fails to build.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] auxdisplay: MAX6959 should select BITREVERSE

[Geert Uytterhoeven]

Hi Andy,

On Thu, 20 Feb 2025 at 09:21, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Thu, Feb 20, 2025 at 9:48 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > If CONFIG_BITREVERSE is not enabled:
> >
> >     max6959.c:(.text+0x92): undefined reference to `byte_rev_table'
>
> LGTM now, thanks.
> Do you think we are in an emergency to send it for v6.14?

No.

> If possible, I would prefer to send this in PR for v6.15 as the
> problem was from day 1 and only bitbot found the configuration so far
> that fails to build.

I had to go through lots of loops to disable BITREVERSE and reproduce
the build issue (e.g. CRC32 selects BITREVERSE), so I doubt anyone
will ever encounter it with a real config.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] auxdisplay: MAX6959 should select BITREVERSE

[Andy Shevchenko]

On Thu, Feb 20, 2025 at 10:07:52AM +0100, Geert Uytterhoeven wrote:
> Hi Andy,
> 
> On Thu, 20 Feb 2025 at 09:21, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Thu, Feb 20, 2025 at 9:48 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > >
> > > If CONFIG_BITREVERSE is not enabled:
> > >
> > >     max6959.c:(.text+0x92): undefined reference to `byte_rev_table'
> >
> > LGTM now, thanks.
> > Do you think we are in an emergency to send it for v6.14?
> 
> No.
> 
> > If possible, I would prefer to send this in PR for v6.15 as the
> > problem was from day 1 and only bitbot found the configuration so far
> > that fails to build.
> 
> I had to go through lots of loops to disable BITREVERSE and reproduce
> the build issue (e.g. CRC32 selects BITREVERSE), so I doubt anyone
> will ever encounter it with a real config.

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko