From: Keith Busch <kbusch@kernel.org>
To: Xinyu Zhang <xizhang@purestorage.com>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Caleb Sander Mateos <csander@purestorage.com>
Subject: Re: [PATCH] nvme: map uring_cmd data even if address is 0
Date: Thu, 20 Feb 2025 16:58:30 -0700 [thread overview]
Message-ID: <Z7fBpnVEBhFPXUR7@kbusch-mbp> (raw)
In-Reply-To: <20250220235101.119852-1-xizhang@purestorage.com>
On Thu, Feb 20, 2025 at 04:51:01PM -0700, Xinyu Zhang wrote:
> When using kernel registered bvec fixed buffers, the "address" is
> actually the offset into the bvec rather than userspace address.
> Therefore it can be 0.
Nice, thanks for catching this.
I'm prepping a new ublk-zc version based on previous feedback. I'll add
this into the series once its ready, and I'm hoping by tomorrow.
next prev parent reply other threads:[~2025-02-20 23:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 23:51 [PATCH] nvme: map uring_cmd data even if address is 0 Xinyu Zhang
2025-02-20 23:58 ` Keith Busch [this message]
2025-02-21 0:55 ` Jens Axboe
2025-02-24 14:33 ` Christoph Hellwig
2025-02-24 14:54 ` Keith Busch
2025-02-24 16:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7fBpnVEBhFPXUR7@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=xizhang@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox