From: Mike Rapoport <rppt@kernel.org>
To: WangYuli <wangyuli@uniontech.com>
Cc: chenhuacai@kernel.org, kernel@xen0n.name, rafael@kernel.org,
lenb@kernel.org, maobibo@loongson.cn, guanwentao@uniontech.com,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
Jonathan.Cameron@huawei.com, dan.j.williams@intel.com,
alison.schofield@intel.com, rrichter@amd.com,
bfaccini@nvidia.com, dave.jiang@intel.com, haibo1.xu@intel.com,
linux-acpi@vger.kernel.org, zhanjun@uniontech.com,
niecheng1@uniontech.com, chenlinxuan@uniontech.com
Subject: Re: [PATCH] ACPI: NUMA: Move get_numa_distances_cnt() helper to needed location
Date: Fri, 21 Feb 2025 14:45:17 +0200 [thread overview]
Message-ID: <Z7h1XWyjKIkyR2zJ@kernel.org> (raw)
In-Reply-To: <13526D98D27F6E36+705ff063-e7f6-49ff-a29a-0f5e5101c000@uniontech.com>
Hi,
On Thu, Feb 20, 2025 at 02:25:33PM +0800, WangYuli wrote:
> Hi Mike,
>
> On 2025/2/20 14:10, Mike Rapoport wrote:
> > There's no need for relocation, just drop the unused function.
>
> Okay.
>
> But please take a look at line 295 of the original srat.c. Should the type
> of variable 'd' there be changed to u64, as mentioned in the commit message?
int is enough for more than 2 million nodes, I don't see a problem with it
> If yes, I can quickly put up another commit just to tweak this one place.
>
> Thanks,
>
> --
> WangYuli
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2025-02-21 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 4:20 [PATCH] ACPI: NUMA: Move get_numa_distances_cnt() helper to needed location WangYuli
2025-02-20 6:10 ` Mike Rapoport
2025-02-20 6:25 ` WangYuli
2025-02-21 12:45 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7h1XWyjKIkyR2zJ@kernel.org \
--to=rppt@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bfaccini@nvidia.com \
--cc=chenhuacai@kernel.org \
--cc=chenlinxuan@uniontech.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=guanwentao@uniontech.com \
--cc=haibo1.xu@intel.com \
--cc=kernel@xen0n.name \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=niecheng1@uniontech.com \
--cc=rafael@kernel.org \
--cc=rrichter@amd.com \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox