public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: srinivas.kandagatla@linaro.org
Cc: broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
	krzysztof.kozlowski@linaro.org, linux-sound@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	dmitry.baryshkov@linaro.org, johan+linaro@kernel.org
Subject: Re: [PATCH v2 0/5] ASoC: q6apm: fix under runs and fragment sizes
Date: Fri, 21 Feb 2025 09:59:40 +0100	[thread overview]
Message-ID: <Z7hAfGHvdeWpZ4Y3@hovoldconsulting.com> (raw)
In-Reply-To: <Z7g5c0_vJNpN9fI4@hovoldconsulting.com>

On Fri, Feb 21, 2025 at 09:29:39AM +0100, Johan Hovold wrote:
> On Thu, Feb 20, 2025 at 06:38:11PM +0100, Johan Hovold wrote:
> > On Thu, Feb 20, 2025 at 04:28:42PM +0000, Srinivas Kandagatla wrote:
> 
> > > On Qualcomm Audioreach setup, some of the audio artifacts are seen in
> > > both recording and playback. These patches fix issues by
> > > 1. Adjusting the fragment size that dsp can service.
> > > 2. schedule available playback buffers in time for dsp to not hit under runs 
> > > 3. remove some of the manual calculations done to get hardware pointer.
> > > 
> > > With these patches, am able to see Audio quality improvements.
> > > 
> > > Any testing would be appreciated.
> > 
> > With this series, the choppy (robotic) capture when using pipewire
> > appears to be fixed (pulseaudio worked before).
> > 
> > Playback is still choppy (heavily distorted), though, and now it also
> > appears to be too slow.
> > 
> > I tested using pw-record and pw-play (and mpv) on the T14s (6.14-rc3).
> 
> Retested this morning and realised that playback is only choppy (and too
> slow) while I have pavucontrol open. That would be nice to fix if
> possible, but this is still a great improvement since pipewire was not
> usable at all before these changes.
> 
> Tested-by: Johan Hovold <johan+linaro@kernel.org>

Hmm... Scratch that.

This series apparently breaks pulseaudio instead.

Too fast playback on the T14s with mpv, and after I stopped it I wasn't
able too play any audio anymore. And systemd complains about a stop job
running for long when rebooting. Similar issues on the X13s.

Johan

  reply	other threads:[~2025-02-21  8:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 16:28 [PATCH v2 0/5] ASoC: q6apm: fix under runs and fragment sizes srinivas.kandagatla
2025-02-20 16:28 ` [PATCH v2 1/5] ASoC: q6apm-dai: schedule all available frames to avoid dsp under-runs srinivas.kandagatla
2025-02-20 16:28 ` [PATCH v2 2/5] ASoC: q6apm: add q6apm_get_hw_pointer helper srinivas.kandagatla
2025-02-20 16:28 ` [PATCH v2 3/5] ASoC: q6apm-dai: make use of q6apm_get_hw_pointer srinivas.kandagatla
2025-02-20 16:58   ` Dmitry Baryshkov
2025-02-20 16:28 ` [PATCH v2 4/5] ASoC: qdsp6: q6apm-dai: set correct period size srinivas.kandagatla
2025-02-20 16:57   ` Dmitry Baryshkov
2025-02-20 16:28 ` [PATCH v2 5/5] ASoC: q6apm-dai: remove redundant hw_constraints setup srinivas.kandagatla
2025-02-20 17:38 ` [PATCH v2 0/5] ASoC: q6apm: fix under runs and fragment sizes Johan Hovold
2025-02-20 17:44   ` Srinivas Kandagatla
2025-02-21  8:29   ` Johan Hovold
2025-02-21  8:59     ` Johan Hovold [this message]
2025-02-21 10:15       ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7hAfGHvdeWpZ4Y3@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=johan+linaro@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox