Re: [PATCH v2 2/2] drm/draw: include bug.h

Raag Jadav
2025-02-21T10:24:41Z

On Fri, Feb 21, 2025 at 10:49:48AM +0100, Simona Vetter wrote:
> On Fri, Feb 21, 2025 at 07:05:12AM +0100, Greg KH wrote:
> > On Fri, Feb 21, 2025 at 10:38:04AM +0530, Raag Jadav wrote:
> > > Directly include bug.h for WARN() helpers instead of relying on
> > > intermediate headers.
> > >
> > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > ---
> > > drivers/gpu/drm/drm_draw.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/drm_draw.c b/drivers/gpu/drm/drm_draw.c
> > > index cb2ad12bce57..0a0e1eebf481 100644
> > > --- a/drivers/gpu/drm/drm_draw.c
> > > +++ b/drivers/gpu/drm/drm_draw.c
> > > @@ -5,6 +5,7 @@
> > > */
> > >
> > > #include <linux/bits.h>
> > > +#include <linux/bug.h>
> > > #include <linux/iosys-map.h>
> > > #include <linux/types.h>
> > >
> > > --
> > > 2.34.1
> > >
> >
> > Does patch 1 break this file without this patch so this series is not in
> > order?
> >
> > I'll be glad to take patch 1 in my tree, but I don't want to break
> > anything else.
>
> Yeah looks inverted. In case this is all there is I'm happy to land this
> patch through your tree, that seems like the simplest approach.

Yep, I messed up the ordering. Let me send out a v3 since I need to fix
nios2 builds anyway.

> Acked-by: Simona Vetter <simona.vetter@ffwll.ch>

Thank you!

Raag