* [PATCH v1] io.h: drop unused headers
@ 2025-02-20 17:33 Raag Jadav
2025-02-21 2:52 ` kernel test robot
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Raag Jadav @ 2025-02-20 17:33 UTC (permalink / raw)
To: arnd, andriy.shevchenko; +Cc: linux-kernel, Raag Jadav
Drop unused headers and type declaration from io.h.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
PS: I'm not very confident about this but thought I'd give it a try.
include/linux/io.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/io.h b/include/linux/io.h
index 40cb2de73f5e..6a6bc4d46d0a 100644
--- a/include/linux/io.h
+++ b/include/linux/io.h
@@ -9,13 +9,10 @@
#include <linux/sizes.h>
#include <linux/types.h>
#include <linux/init.h>
-#include <linux/bug.h>
-#include <linux/err.h>
#include <asm/io.h>
#include <asm/page.h>
struct device;
-struct resource;
#ifndef __iowrite32_copy
void __iowrite32_copy(void __iomem *to, const void *from, size_t count);
base-commit: b16e9f8547a328b19af59afc213ce323124d11e9
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1] io.h: drop unused headers
2025-02-20 17:33 [PATCH v1] io.h: drop unused headers Raag Jadav
@ 2025-02-21 2:52 ` kernel test robot
2025-02-21 16:07 ` Andy Shevchenko
2025-02-21 3:22 ` kernel test robot
2025-02-21 16:06 ` Andy Shevchenko
2 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2025-02-21 2:52 UTC (permalink / raw)
To: Raag Jadav, arnd, andriy.shevchenko
Cc: oe-kbuild-all, linux-kernel, Raag Jadav
Hi Raag,
kernel test robot noticed the following build errors:
[auto build test ERROR on b16e9f8547a328b19af59afc213ce323124d11e9]
url: https://github.com/intel-lab-lkp/linux/commits/Raag-Jadav/io-h-drop-unused-headers/20250221-013530
base: b16e9f8547a328b19af59afc213ce323124d11e9
patch link: https://lore.kernel.org/r/20250220173305.2752125-1-raag.jadav%40intel.com
patch subject: [PATCH v1] io.h: drop unused headers
config: sparc-randconfig-001-20250221 (https://download.01.org/0day-ci/archive/20250221/202502211009.s6xoWtae-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250221/202502211009.s6xoWtae-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502211009.s6xoWtae-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/gpu/drm/drm_draw.c: In function 'drm_draw_color_from_xrgb8888':
>> drivers/gpu/drm/drm_draw.c:130:17: error: implicit declaration of function 'WARN_ONCE' [-Wimplicit-function-declaration]
130 | WARN_ONCE(1, "Can't convert to %p4cc\n", &format);
| ^~~~~~~~~
vim +/WARN_ONCE +130 drivers/gpu/drm/drm_draw.c
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 93
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 94 /**
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 95 * drm_draw_color_from_xrgb8888 - convert one pixel from xrgb8888 to the desired format
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 96 * @color: input color, in xrgb8888 format
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 97 * @format: output format
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 98 *
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 99 * Returns:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 100 * Color in the format specified, casted to u32.
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 101 * Or 0 if the format is not supported.
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 102 */
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 103 u32 drm_draw_color_from_xrgb8888(u32 color, u32 format)
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 104 {
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 105 switch (format) {
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 106 case DRM_FORMAT_RGB565:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 107 return convert_xrgb8888_to_rgb565(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 108 case DRM_FORMAT_RGBA5551:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 109 return convert_xrgb8888_to_rgba5551(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 110 case DRM_FORMAT_XRGB1555:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 111 return convert_xrgb8888_to_xrgb1555(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 112 case DRM_FORMAT_ARGB1555:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 113 return convert_xrgb8888_to_argb1555(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 114 case DRM_FORMAT_RGB888:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 115 case DRM_FORMAT_XRGB8888:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 116 return color;
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 117 case DRM_FORMAT_ARGB8888:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 118 return convert_xrgb8888_to_argb8888(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 119 case DRM_FORMAT_XBGR8888:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 120 return convert_xrgb8888_to_xbgr8888(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 121 case DRM_FORMAT_ABGR8888:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 122 return convert_xrgb8888_to_abgr8888(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 123 case DRM_FORMAT_XRGB2101010:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 124 return convert_xrgb8888_to_xrgb2101010(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 125 case DRM_FORMAT_ARGB2101010:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 126 return convert_xrgb8888_to_argb2101010(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 127 case DRM_FORMAT_ABGR2101010:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 128 return convert_xrgb8888_to_abgr2101010(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 129 default:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 @130 WARN_ONCE(1, "Can't convert to %p4cc\n", &format);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 131 return 0;
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 132 }
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 133 }
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 134 EXPORT_SYMBOL(drm_draw_color_from_xrgb8888);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 135
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] io.h: drop unused headers
2025-02-21 2:52 ` kernel test robot
@ 2025-02-21 16:07 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-02-21 16:07 UTC (permalink / raw)
To: kernel test robot; +Cc: Raag Jadav, arnd, oe-kbuild-all, linux-kernel
On Fri, Feb 21, 2025 at 10:52:12AM +0800, kernel test robot wrote:
> Hi Raag,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on b16e9f8547a328b19af59afc213ce323124d11e9]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Raag-Jadav/io-h-drop-unused-headers/20250221-013530
> base: b16e9f8547a328b19af59afc213ce323124d11e9
> patch link: https://lore.kernel.org/r/20250220173305.2752125-1-raag.jadav%40intel.com
> patch subject: [PATCH v1] io.h: drop unused headers
> config: sparc-randconfig-001-20250221 (https://download.01.org/0day-ci/archive/20250221/202502211009.s6xoWtae-lkp@intel.com/config)
> compiler: sparc64-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250221/202502211009.s6xoWtae-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202502211009.s6xoWtae-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> drivers/gpu/drm/drm_draw.c: In function 'drm_draw_color_from_xrgb8888':
> >> drivers/gpu/drm/drm_draw.c:130:17: error: implicit declaration of function 'WARN_ONCE' [-Wimplicit-function-declaration]
> 130 | WARN_ONCE(1, "Can't convert to %p4cc\n", &format);
> | ^~~~~~~~~
dwm_draw.c misses linux/bug.h.
Raag, please add it to your patch. But let's wait at least a week that CIs can
collect more issues, if any, along with people, who want to test this change.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] io.h: drop unused headers
2025-02-20 17:33 [PATCH v1] io.h: drop unused headers Raag Jadav
2025-02-21 2:52 ` kernel test robot
@ 2025-02-21 3:22 ` kernel test robot
2025-02-21 16:10 ` Andy Shevchenko
2025-02-21 16:06 ` Andy Shevchenko
2 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2025-02-21 3:22 UTC (permalink / raw)
To: Raag Jadav, arnd, andriy.shevchenko
Cc: oe-kbuild-all, linux-kernel, Raag Jadav
Hi Raag,
kernel test robot noticed the following build errors:
[auto build test ERROR on b16e9f8547a328b19af59afc213ce323124d11e9]
url: https://github.com/intel-lab-lkp/linux/commits/Raag-Jadav/io-h-drop-unused-headers/20250221-013530
base: b16e9f8547a328b19af59afc213ce323124d11e9
patch link: https://lore.kernel.org/r/20250220173305.2752125-1-raag.jadav%40intel.com
patch subject: [PATCH v1] io.h: drop unused headers
config: nios2-randconfig-001-20250221 (https://download.01.org/0day-ci/archive/20250221/202502211137.IRE8qrlR-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250221/202502211137.IRE8qrlR-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502211137.IRE8qrlR-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
drivers/gpu/drm/drm_draw.c: In function 'drm_draw_color_from_xrgb8888':
drivers/gpu/drm/drm_draw.c:130:17: error: implicit declaration of function 'WARN_ONCE' [-Wimplicit-function-declaration]
130 | WARN_ONCE(1, "Can't convert to %p4cc\n", &format);
| ^~~~~~~~~
drivers/gpu/drm/drm_draw.c: At top level:
>> drivers/gpu/drm/drm_draw.c:134:1: warning: data definition has no type or storage class
134 | EXPORT_SYMBOL(drm_draw_color_from_xrgb8888);
| ^~~~~~~~~~~~~
>> drivers/gpu/drm/drm_draw.c:134:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
>> drivers/gpu/drm/drm_draw.c:134:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/gpu/drm/drm_draw.c:151:1: warning: data definition has no type or storage class
151 | EXPORT_SYMBOL(drm_draw_blit16);
| ^~~~~~~~~~~~~
drivers/gpu/drm/drm_draw.c:151:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/gpu/drm/drm_draw.c:151:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/gpu/drm/drm_draw.c:173:1: warning: data definition has no type or storage class
173 | EXPORT_SYMBOL(drm_draw_blit24);
| ^~~~~~~~~~~~~
drivers/gpu/drm/drm_draw.c:173:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/gpu/drm/drm_draw.c:173:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/gpu/drm/drm_draw.c:187:1: warning: data definition has no type or storage class
187 | EXPORT_SYMBOL(drm_draw_blit32);
| ^~~~~~~~~~~~~
drivers/gpu/drm/drm_draw.c:187:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/gpu/drm/drm_draw.c:187:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/gpu/drm/drm_draw.c:202:1: warning: data definition has no type or storage class
202 | EXPORT_SYMBOL(drm_draw_fill16);
| ^~~~~~~~~~~~~
drivers/gpu/drm/drm_draw.c:202:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/gpu/drm/drm_draw.c:202:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/gpu/drm/drm_draw.c:221:1: warning: data definition has no type or storage class
221 | EXPORT_SYMBOL(drm_draw_fill24);
| ^~~~~~~~~~~~~
drivers/gpu/drm/drm_draw.c:221:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/gpu/drm/drm_draw.c:221:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/gpu/drm/drm_draw.c:233:1: warning: data definition has no type or storage class
233 | EXPORT_SYMBOL(drm_draw_fill32);
| ^~~~~~~~~~~~~
drivers/gpu/drm/drm_draw.c:233:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/gpu/drm/drm_draw.c:233:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
vim +134 drivers/gpu/drm/drm_draw.c
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 93
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 94 /**
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 95 * drm_draw_color_from_xrgb8888 - convert one pixel from xrgb8888 to the desired format
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 96 * @color: input color, in xrgb8888 format
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 97 * @format: output format
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 98 *
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 99 * Returns:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 100 * Color in the format specified, casted to u32.
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 101 * Or 0 if the format is not supported.
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 102 */
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 103 u32 drm_draw_color_from_xrgb8888(u32 color, u32 format)
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 104 {
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 105 switch (format) {
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 106 case DRM_FORMAT_RGB565:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 107 return convert_xrgb8888_to_rgb565(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 108 case DRM_FORMAT_RGBA5551:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 109 return convert_xrgb8888_to_rgba5551(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 110 case DRM_FORMAT_XRGB1555:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 111 return convert_xrgb8888_to_xrgb1555(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 112 case DRM_FORMAT_ARGB1555:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 113 return convert_xrgb8888_to_argb1555(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 114 case DRM_FORMAT_RGB888:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 115 case DRM_FORMAT_XRGB8888:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 116 return color;
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 117 case DRM_FORMAT_ARGB8888:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 118 return convert_xrgb8888_to_argb8888(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 119 case DRM_FORMAT_XBGR8888:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 120 return convert_xrgb8888_to_xbgr8888(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 121 case DRM_FORMAT_ABGR8888:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 122 return convert_xrgb8888_to_abgr8888(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 123 case DRM_FORMAT_XRGB2101010:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 124 return convert_xrgb8888_to_xrgb2101010(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 125 case DRM_FORMAT_ARGB2101010:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 126 return convert_xrgb8888_to_argb2101010(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 127 case DRM_FORMAT_ABGR2101010:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 128 return convert_xrgb8888_to_abgr2101010(color);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 129 default:
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 @130 WARN_ONCE(1, "Can't convert to %p4cc\n", &format);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 131 return 0;
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 132 }
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 133 }
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 @134 EXPORT_SYMBOL(drm_draw_color_from_xrgb8888);
31fa2c1ca0b239 Jocelyn Falempe 2024-12-04 135
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] io.h: drop unused headers
2025-02-21 3:22 ` kernel test robot
@ 2025-02-21 16:10 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-02-21 16:10 UTC (permalink / raw)
To: kernel test robot; +Cc: Raag Jadav, arnd, oe-kbuild-all, linux-kernel
On Fri, Feb 21, 2025 at 11:22:38AM +0800, kernel test robot wrote:
> Hi Raag,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on b16e9f8547a328b19af59afc213ce323124d11e9]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Raag-Jadav/io-h-drop-unused-headers/20250221-013530
> base: b16e9f8547a328b19af59afc213ce323124d11e9
> patch link: https://lore.kernel.org/r/20250220173305.2752125-1-raag.jadav%40intel.com
> patch subject: [PATCH v1] io.h: drop unused headers
> config: nios2-randconfig-001-20250221 (https://download.01.org/0day-ci/archive/20250221/202502211137.IRE8qrlR-lkp@intel.com/config)
> compiler: nios2-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250221/202502211137.IRE8qrlR-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202502211137.IRE8qrlR-lkp@intel.com/
...
> drivers/gpu/drm/drm_draw.c: At top level:
> >> drivers/gpu/drm/drm_draw.c:134:1: warning: data definition has no type or storage class
> 134 | EXPORT_SYMBOL(drm_draw_color_from_xrgb8888);
> | ^~~~~~~~~~~~~
> >> drivers/gpu/drm/drm_draw.c:134:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> >> drivers/gpu/drm/drm_draw.c:134:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
> drivers/gpu/drm/drm_draw.c:151:1: warning: data definition has no type or storage class
> 151 | EXPORT_SYMBOL(drm_draw_blit16);
> | ^~~~~~~~~~~~~
I haven't looked deeply into this, but it might be the export.h is missing
or it's just a followup of missing bug.h. In any case the io.h patch needs
a prerequisite for dwm_draw.c to eliminate usage of "proxy" headers and follow
IWYU principle. So, it will become a series of two. But as I said before,
let's wait a bit longer.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] io.h: drop unused headers
2025-02-20 17:33 [PATCH v1] io.h: drop unused headers Raag Jadav
2025-02-21 2:52 ` kernel test robot
2025-02-21 3:22 ` kernel test robot
@ 2025-02-21 16:06 ` Andy Shevchenko
2 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-02-21 16:06 UTC (permalink / raw)
To: Raag Jadav; +Cc: arnd, linux-kernel
On Thu, Feb 20, 2025 at 11:03:05PM +0530, Raag Jadav wrote:
> Drop unused headers and type declaration from io.h.
FWIW,
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> PS: I'm not very confident about this but thought I'd give it a try.
Sure, I like this change.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-02-21 16:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-20 17:33 [PATCH v1] io.h: drop unused headers Raag Jadav
2025-02-21 2:52 ` kernel test robot
2025-02-21 16:07 ` Andy Shevchenko
2025-02-21 3:22 ` kernel test robot
2025-02-21 16:10 ` Andy Shevchenko
2025-02-21 16:06 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox