From: Andy Shevchenko <andy@kernel.org>
To: Haoxiang Li <haoxiang_li2024@163.com>
Cc: geert@linux-m68k.org, u.kleine-koenig@pengutronix.de,
erick.archer@outlook.com, ojeda@kernel.org, w@1wt.eu,
poeschel@lemonage.de, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] auxdisplay: hd44780: Fix an API misuse in hd44780.c
Date: Mon, 24 Feb 2025 14:35:40 +0200 [thread overview]
Message-ID: <Z7xnnPaoHfz7lYyi@smile.fi.intel.com> (raw)
In-Reply-To: <20250224101527.2971012-1-haoxiang_li2024@163.com>
On Mon, Feb 24, 2025 at 06:15:27PM +0800, Haoxiang Li wrote:
> Variable allocated by charlcd_alloc() should be released
> by charlcd_free(). The following patch changed kfree() to
> charlcd_free() to fix an API misuse.
> Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")
> Cc: stable@vger.kernel.org
Okay, looking closer to the current state of affairs, the change
does not fix anything actually. OTOH it's correct semantically and
allows to do any further development in charlcd_alloc(), if any.
That said, if Geert is okay with it, I would like to apply but without
Fixes/Cc: stable@ tags.
P.S.
The very similar needs to be applied to panel.c, but I already have
a patch for that locally, thanks to this thread.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-24 12:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 10:15 [PATCH v2] auxdisplay: hd44780: Fix an API misuse in hd44780.c Haoxiang Li
2025-02-24 10:36 ` Andy Shevchenko
2025-02-24 10:39 ` Andy Shevchenko
2025-02-24 12:30 ` Geert Uytterhoeven
2025-02-24 12:36 ` Andy Shevchenko
2025-02-24 12:35 ` Andy Shevchenko [this message]
2025-02-24 13:33 ` Geert Uytterhoeven
2025-02-24 13:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7xnnPaoHfz7lYyi@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=erick.archer@outlook.com \
--cc=geert@linux-m68k.org \
--cc=haoxiang_li2024@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=poeschel@lemonage.de \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox