From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59C29261578 for ; Mon, 24 Feb 2025 15:49:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740412178; cv=none; b=q62qG05S3a0B7vUMr9BarDTgcsWMDcE4vdJIPxK9AWMz+xSQGMyrzd0LurCtGtRJWu7aJUcqkITygr8YOAnopd7lxkfB9b7PsS7hQ0uHvt9lzjru0F+1jJPprWtQgWFpk8HklOWS/5ZLGArgsHNdioR0q2KnZeOJ6b6NH7VA5tM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740412178; c=relaxed/simple; bh=kIgQ44rc/tULacbSzqYNepzgyg03jclsgYTvnH/mowM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UuejYvJtd+/VKf4CSEbC6Nh/atSt5tGbK57S3ApGopSfUvTASiQ6UWhOWjI81ucXC5OhcrP2w57KLsPzJvUKQ3FPCLaIbkM14qSkwntG0xPkgbMo71uhY0UjOjVmWVh/9Q4qc2Ri/YtODt528lf6OaLNCCTEdrj+omI+pwWpcrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Vn1v+OBA; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Vn1v+OBA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740412177; x=1771948177; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=kIgQ44rc/tULacbSzqYNepzgyg03jclsgYTvnH/mowM=; b=Vn1v+OBAU03MP5R+7tmvP5PUFXj16e6/dm6O0SnC7Q4XecaWrY6+4Jua tyBcxu+ri+vrFJjMOkP2gw8/xSygNswvMcuInVYUBu7x+QpMUK3V5elu3 UQUlDGSpdUBCyQidwBdt0/gCvvjwiN3mUXLfItE7Su9PMcV3oFOPw0ZNc Xb2gwS+sT9W8n9OP0K/6kBj0W72n7TWw31XFKNS7oTXWu90vcg6m/W2Fc nrGMRSDPUzxCiCZeJ2foMmWGXYSo3R+mNWhI+Ak9bdcxUGR6wkI77O1Xt Ac+xHlhi+GrQSCgd8evaxyMJwWskQmNBVBjP/r9m1tKjrbglh32CY0CMf Q==; X-CSE-ConnectionGUID: sMUTZNBCQ9qcW/ITZ2bZAQ== X-CSE-MsgGUID: H7V1Qw7NSjS9b7f158F7kA== X-IronPort-AV: E=McAfee;i="6700,10204,11355"; a="41083136" X-IronPort-AV: E=Sophos;i="6.13,309,1732608000"; d="scan'208";a="41083136" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 07:49:36 -0800 X-CSE-ConnectionGUID: RXmPiNT6SG2/Oyo+UUq0nw== X-CSE-MsgGUID: l0c7BmLRSruAi/dHsQSDqA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,309,1732608000"; d="scan'208";a="116071242" Received: from smile.fi.intel.com ([10.237.72.58]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 07:49:33 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tmai2-0000000Ejqm-00kF; Mon, 24 Feb 2025 17:49:30 +0200 Date: Mon, 24 Feb 2025 17:49:29 +0200 From: "andriy.shevchenko@linux.intel.com" To: Aditya Garg Cc: "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "tzimmermann@suse.de" , "airlied@gmail.com" , "simona@ffwll.ch" , Kerem Karabay , Atharva Tiwari , Aun-Ali Zaidi , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" Subject: Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Feb 24, 2025 at 03:39:56PM +0000, Aditya Garg wrote: > > On 24 Feb 2025, at 9:07 PM, andriy.shevchenko@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 03:20:13PM +0000, Aditya Garg wrote: > >>>> On 24 Feb 2025, at 8:41 PM, andriy.shevchenko@linux.intel.com wrote: > >>> On Mon, Feb 24, 2025 at 03:03:40PM +0000, Aditya Garg wrote: > >>>>>> On 24 Feb 2025, at 8:27 PM, andriy.shevchenko@linux.intel.com wrote: > >>>>> On Mon, Feb 24, 2025 at 02:32:37PM +0000, Aditya Garg wrote: > >>>>>>> On 24 Feb 2025, at 7:30 PM, andriy.shevchenko@linux.intel.com wrote: > >>>>>>> On Mon, Feb 24, 2025 at 01:40:20PM +0000, Aditya Garg wrote: ... > >>>>>>>> +#define __APPLETBDRM_MSG_STR4(str4) ((__le32 __force)((str4[0] << 24) | (str4[1] << 16) | (str4[2] << 8) | str4[3])) > >>>>>>> > >>>>>>> As commented previously this is quite strange what's going on with endianess in > >>>>>>> this driver. Especially the above weirdness when get_unaligned_be32() is being > >>>>>>> open coded and force-cast to __le32. > >>>>>> > >>>>>> I would assume it was also mimicked from the Windows driver, though I haven't > >>>>>> really tried exploring this there. > >>>>>> > >>>>>> I’d rather be happy if you give me code change suggestions and let me review > >>>>>> and test them > >>>>> > >>>>> For the starter I would do the following for all related constants and > >>>>> drop that weird and ugly macros at the top (it also has an issue with > >>>>> the str4 length as it is 5 bytes long, not 4, btw): > >>>>> > >>>>> #define APPLETBDRM_MSG_CLEAR_DISPLAY cpu_to_le32(0x434c5244) /* CLRD */ > >>>> > >>>> Lemme test this. > >>> > >>> Just in case it won't work, reverse bytes in the integer. Because I was lost in > >>> this conversion. > >> > >> It works. What I understand is that you used the macro to get the final hex > >> and converted it into little endian, which on the x86 macs would technically > >> remain the same. > > The Macro is just converting the letters into their hex form, but simply > calculating them and putting the letters in comments is equally good. Again, it does it in most confusing and weird way. Just kill it. > > Right, the problem is the macro itself which does really weird things altogether. > > Using integer + comment much clearer in my opinion. > > > >>>>> (assuming we stick with __leXX for now). This will be much less confusing. -- With Best Regards, Andy Shevchenko