From: Liviu Dudau <liviu.dudau@arm.com>
To: WangYuli <wangyuli@uniontech.com>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
zhanjun@uniontech.com, niecheng1@uniontech.com,
guanwentao@uniontech.com, chenlinxuan@uniontech.com
Subject: Re: [PATCH] drm/arm: Suppress "ARM devices" menu if not essential
Date: Mon, 10 Mar 2025 10:52:34 +0000 [thread overview]
Message-ID: <Z87EcmftDZ1QOLL0@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <D20815A68EE4902F+20250310072357.52841-1-wangyuli@uniontech.com>
On Mon, Mar 10, 2025 at 03:23:57PM +0800, WangYuli wrote:
> Manifestly, the "ARM devices" menu is appropriate only for the ARM
> architecture.
>
> Inasmuch as every single item in this menu is predicated on
> (ARM || ARM64 || COMPILE_TEST), it is therefore illogical for the
> "ARM devices" menu itself not to be predicated upon
> (ARM || ARM64 || COMPILE_TEST), and displaying a blank menu in other
> architectures is unwarranted.
Arm's Display IP is not tied to the Arm architecture. Anyone can license
and use the IP with any CPU architecture. The fact that so far the IP has
only been present in a handful of devices doesn't mean we should restrict
the drivers.
What is the issue that you're trying to solve here?
Best regards,
Liviu
>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
> drivers/gpu/drm/arm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> index c901ac00c0c3..0aa6a54567b6 100644
> --- a/drivers/gpu/drm/arm/Kconfig
> +++ b/drivers/gpu/drm/arm/Kconfig
> @@ -1,6 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0
> menu "ARM devices"
> - depends on DRM
> + depends on DRM && (ARM || ARM64 || COMPILE_TEST)
>
> config DRM_HDLCD
> tristate "ARM HDLCD"
> --
> 2.47.2
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
prev parent reply other threads:[~2025-03-10 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 7:23 [PATCH] drm/arm: Suppress "ARM devices" menu if not essential WangYuli
2025-03-10 10:52 ` Liviu Dudau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z87EcmftDZ1QOLL0@e110455-lin.cambridge.arm.com \
--to=liviu.dudau@arm.com \
--cc=airlied@gmail.com \
--cc=chenlinxuan@uniontech.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=guanwentao@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=niecheng1@uniontech.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox