From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp-crd: add support for volume-up key
Date: Mon, 10 Mar 2025 13:18:19 +0100 [thread overview]
Message-ID: <Z87Yi6IQEIhqu27O@hovoldconsulting.com> (raw)
In-Reply-To: <2aac1aff-694f-41f6-8849-f1dfe802a1f4@oss.qualcomm.com>
On Sat, Mar 08, 2025 at 05:26:26PM +0100, Konrad Dybcio wrote:
> On 7.03.2025 6:10 PM, Johan Hovold wrote:
> > Add support for the keypad volume-up key on the debug extension board.
> >
> > This is useful to have when testing PMIC interrupt handling, and the key
> > can also be used to wake up from deep suspend states (CX shutdown).
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>
> I'm lukewarm about this since there is no "actual" button for that.
There is certainly a physical button on the debug board. And the UEFI
firmware also supports it (e.g. it can be used in GRUB).
> Does the power button not work here?
For wake up, yes, but not for testing PMIC GPIO interrupts.
> If systemd induces a shutdown, try setting
>
> HandlePowerKey=ignore
>
> in /etc/systemd/logind.conf
I'm aware of that, but the volume key can be used without updating user
space (possibly also for CI testing if that signal can be controlled
remotely like the power button).
Johan
next prev parent reply other threads:[~2025-03-10 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 17:10 [PATCH] arm64: dts: qcom: sc8280xp-crd: add support for volume-up key Johan Hovold
2025-03-08 16:26 ` Konrad Dybcio
2025-03-10 12:18 ` Johan Hovold [this message]
2025-03-11 17:26 ` Konrad Dybcio
2025-03-17 2:55 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z87Yi6IQEIhqu27O@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox