From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B24D81B4241 for ; Thu, 27 Feb 2025 16:46:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740674788; cv=none; b=UcrexbWvr7I5cw2DNgao149qaixBIgN8A/XibOZaIrLpqeaGy/nJswfp2KNcQctrFT4l5qxxTM6zyOsUa0NzA1e6sCg2G8fR+LhLwTw5eSmxauVRtQO3JrMxyaYH8pICDKIJ8Zqpu2FPES1GpUR3t3woj2NuKpN96w087jskmFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740674788; c=relaxed/simple; bh=67tiD0TMFvksK5IXmgM9ni7fSjLJOtAe0ZBDW22/UDc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iHmY/aa/a6c2FgLk9WezXic+wBz0rQ4SllV0a0yE0/WDDv1C9/fo+CeQ7D+0CE7rANcnyQB9JFD5mxm1puAQxSq1U1BOaqUrD2H+GDJOHxfZJrWrkEBXHNA8LLOxivrYt3S9y3HvF1CRgL5gtg7A4ctt3pK6vmhYwLDn9CR44Kk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mbx/yjtE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mbx/yjtE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D75ECC4CEE6; Thu, 27 Feb 2025 16:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740674788; bh=67tiD0TMFvksK5IXmgM9ni7fSjLJOtAe0ZBDW22/UDc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mbx/yjtEVKHpXuRUPwgSu7KQiN+nc2mlvt859QZKoEEYoWIeBVczJ+ypaAXbo4c5t 6pUbkFY4jV0x1rXVCXuGnNxDkgw10yMV6tO9CicxBgNROQgwmgbfvW3OVRszmd69CY jfhgGfWnNul9K3TBK0v5UEsnw4JCzTPk+HtFOScKxRcFDeuLE72sz8Q3YkOdG+iLfP Uspywu3dolEngk3tnUHnQ7Nrmxn4FZcrrIetAJEPxY6SmJ3cK/y0UL0nIErrkXmhov yzRGltt2dErPf+YzbjMU002Yl5QEwvBg0liWxPvpesbkkvIWfuRB8Xg7blQoC7NWyY QLR4D7jwMTPIg== Date: Thu, 27 Feb 2025 08:46:26 -0800 From: Namhyung Kim To: Ian Rogers , Josh Poimboeuf Cc: Adrian Hunter , Ingo Molnar , Al Viro , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Peter Zijlstra Subject: Re: [PATCH v1] x86/insn: Fix linux/unaligned.h include path Message-ID: References: <20250225193600.90037-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Adding Josh and Peter as it's used in objtool as well. On Wed, Feb 26, 2025 at 04:32:20PM -0800, Namhyung Kim wrote: > On Tue, Feb 25, 2025 at 11:36:00AM -0800, Ian Rogers wrote: > > tools/arch/x86/include/linux doesn't exist but building is working by > > virtue of a -I. Building using bazel this fails. Use angle brackets to > > include unaligned.h so there isn't an invalid relative include. > > Right, it's using tools/include/linux/unaligned.h. Josh, are you ok with this? I can carry this in the perf tools tree if you don't mind. Thanks, Namhyung > > > > > Fixes: 5f60d5f6bbc1 ("move asm/unaligned.h to linux/unaligned.h") > > Signed-off-by: Ian Rogers > > --- > > tools/arch/x86/lib/insn.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c > > index ab5cdc3337da..e91d4c4e1c16 100644 > > --- a/tools/arch/x86/lib/insn.c > > +++ b/tools/arch/x86/lib/insn.c > > @@ -13,7 +13,7 @@ > > #endif > > #include "../include/asm/inat.h" /* __ignore_sync_check__ */ > > #include "../include/asm/insn.h" /* __ignore_sync_check__ */ > > -#include "../include/linux/unaligned.h" /* __ignore_sync_check__ */ > > +#include /* __ignore_sync_check__ */ > > > > #include > > #include > > -- > > 2.48.1.711.g2feabab25a-goog > >