Re: Unwired pvrdma_modify_device ?

Bryan Tan
2025-03-04T13:26:08Z

[-- Attachment #1.1: Type: text/plain, Size: 893 bytes --]

On Mon, Mar 3, 2025 at 6:42 PM Dr. David Alan Gilbert <linux@treblig.org>
wrote:
> * Jason Gunthorpe (jgg@ziepe.ca) wrote:
> > On Sun, Mar 02, 2025 at 10:05:11PM +0000, Dr. David Alan Gilbert wrote:
> > > Hi,
> > > I noticed that pvrdma_modify_device() in
> > > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> > > isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ?
> > >
> > > (I've not got VMWare anywhere to try it on, and don't know the innards
> > > of RDMA drivers; so can't really test it).
>
> Hi Jason,
> Thanks for the reply,
>
> > Seems probably right
> >
> > But at this point I'd just delete it unless pvrdma maintainers say
> > otherwise in the next week
>
> OK, lets see if they wake up.
>
> Dave

Thanks David for bringing this up. You're right, it looks like we
never wired it up to pvrdma_dev_ops. Feel free to remove it.

[-- Attachment #1.2: Type: text/html, Size: 1225 bytes --]

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5430 bytes --]