Re: Unwired pvrdma_modify_device ?

Dr. David Alan Gilbert
2025-03-04T21:58:27Z

* Dr. David Alan Gilbert (linux@treblig.org) wrote:
> * Bryan Tan (bryan-bt.tan@broadcom.com) wrote:
> > On Mon, Mar 3, 2025 at 6:42 PM Dr. David Alan Gilbert <linux@treblig.org>
> > wrote:
> > > * Jason Gunthorpe (jgg@ziepe.ca) wrote:
> > > > On Sun, Mar 02, 2025 at 10:05:11PM +0000, Dr. David Alan Gilbert wrote:
> > > > > Hi,
> > > > > I noticed that pvrdma_modify_device() in
> > > > > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> > > > > isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ?
> > > > >
> > > > > (I've not got VMWare anywhere to try it on, and don't know the innards
> > > > > of RDMA drivers; so can't really test it).
> > >
> > > Hi Jason,
> > > Thanks for the reply,
> > >
> > > > Seems probably right
> > > >
> > > > But at this point I'd just delete it unless pvrdma maintainers say
> > > > otherwise in the next week
> > >
> > > OK, lets see if they wake up.
> > >
> > > Dave
> >
> > Thanks David for bringing this up. You're right, it looks like we
> > never wired it up to pvrdma_dev_ops. Feel free to remove it.
>
> Hi Bryan,
> Thanks for the reply - OK, I'll send a patch later to remove it.

Just sent, See 20250304215637.68559-1-linux@treblig.org

Dave

> Dave
>
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ dave @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/