Re: [PATCH v2 2/5] gpio: elkhartlake: depend on MFD_INTEL_EHL_PSE_GPIO

Andy Shevchenko
2025-03-03T08:21:18Z

On Mon, Mar 03, 2025 at 10:17:42AM +0530, Raag Jadav wrote:
> Now that we have Intel MFD driver for PSE GPIO, depend on it.

...

> config GPIO_ELKHARTLAKE
> tristate "Intel Elkhart Lake PSE GPIO support"
> - depends on X86 || COMPILE_TEST
> + depends on (X86 && MFD_INTEL_EHL_PSE_GPIO) || COMPILE_TEST
> select GPIO_TANGIER

Looking on how GPIO PMIC drivers are written, I would redo this as

depends on (X86 || COMPILE_TEST) && MFD_INTEL_EHL_PSE_GPIO

--
With Best Regards,
Andy Shevchenko