From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: bryan-bt.tan@broadcom.com, vishnu.dasa@broadcom.com,
leon@kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Unwired pvrdma_modify_device ?
Date: Mon, 3 Mar 2025 18:42:11 +0000 [thread overview]
Message-ID: <Z8X4Ax5UCerz9lP8@gallifrey> (raw)
In-Reply-To: <20250303182629.GV5011@ziepe.ca>
* Jason Gunthorpe (jgg@ziepe.ca) wrote:
> On Sun, Mar 02, 2025 at 10:05:11PM +0000, Dr. David Alan Gilbert wrote:
> > Hi,
> > I noticed that pvrdma_modify_device() in
> > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> > isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ?
> >
> > (I've not got VMWare anywhere to try it on, and don't know the innards
> > of RDMA drivers; so can't really test it).
Hi Jason,
Thanks for the reply,
> Seems probably right
>
> But at this point I'd just delete it unless pvrdma maintainers say
> otherwise in the next week
OK, lets see if they wake up.
Dave
> Jason
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2025-03-03 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 22:05 Unwired pvrdma_modify_device ? Dr. David Alan Gilbert
2025-03-03 18:26 ` Jason Gunthorpe
2025-03-03 18:42 ` Dr. David Alan Gilbert [this message]
2025-03-04 13:25 ` Bryan Tan
2025-03-04 15:39 ` Dr. David Alan Gilbert
2025-03-04 21:58 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8X4Ax5UCerz9lP8@gallifrey \
--to=linux@treblig.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bryan-bt.tan@broadcom.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=vishnu.dasa@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox