* Unwired pvrdma_modify_device ? @ 2025-03-02 22:05 Dr. David Alan Gilbert 2025-03-03 18:26 ` Jason Gunthorpe 0 siblings, 1 reply; 6+ messages in thread From: Dr. David Alan Gilbert @ 2025-03-02 22:05 UTC (permalink / raw) To: bryan-bt.tan, vishnu.dasa, jgg, leon Cc: bcm-kernel-feedback-list, linux-rdma, linux-kernel Hi, I noticed that pvrdma_modify_device() in drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ? (I've not got VMWare anywhere to try it on, and don't know the innards of RDMA drivers; so can't really test it). Dave -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Unwired pvrdma_modify_device ? 2025-03-02 22:05 Unwired pvrdma_modify_device ? Dr. David Alan Gilbert @ 2025-03-03 18:26 ` Jason Gunthorpe 2025-03-03 18:42 ` Dr. David Alan Gilbert 0 siblings, 1 reply; 6+ messages in thread From: Jason Gunthorpe @ 2025-03-03 18:26 UTC (permalink / raw) To: Dr. David Alan Gilbert Cc: bryan-bt.tan, vishnu.dasa, leon, bcm-kernel-feedback-list, linux-rdma, linux-kernel On Sun, Mar 02, 2025 at 10:05:11PM +0000, Dr. David Alan Gilbert wrote: > Hi, > I noticed that pvrdma_modify_device() in > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c > isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ? > > (I've not got VMWare anywhere to try it on, and don't know the innards > of RDMA drivers; so can't really test it). Seems probably right But at this point I'd just delete it unless pvrdma maintainers say otherwise in the next week Jason ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Unwired pvrdma_modify_device ? 2025-03-03 18:26 ` Jason Gunthorpe @ 2025-03-03 18:42 ` Dr. David Alan Gilbert 2025-03-04 13:25 ` Bryan Tan 0 siblings, 1 reply; 6+ messages in thread From: Dr. David Alan Gilbert @ 2025-03-03 18:42 UTC (permalink / raw) To: Jason Gunthorpe Cc: bryan-bt.tan, vishnu.dasa, leon, bcm-kernel-feedback-list, linux-rdma, linux-kernel * Jason Gunthorpe (jgg@ziepe.ca) wrote: > On Sun, Mar 02, 2025 at 10:05:11PM +0000, Dr. David Alan Gilbert wrote: > > Hi, > > I noticed that pvrdma_modify_device() in > > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c > > isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ? > > > > (I've not got VMWare anywhere to try it on, and don't know the innards > > of RDMA drivers; so can't really test it). Hi Jason, Thanks for the reply, > Seems probably right > > But at this point I'd just delete it unless pvrdma maintainers say > otherwise in the next week OK, lets see if they wake up. Dave > Jason -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Unwired pvrdma_modify_device ? 2025-03-03 18:42 ` Dr. David Alan Gilbert @ 2025-03-04 13:25 ` Bryan Tan 2025-03-04 15:39 ` Dr. David Alan Gilbert 0 siblings, 1 reply; 6+ messages in thread From: Bryan Tan @ 2025-03-04 13:25 UTC (permalink / raw) To: Dr. David Alan Gilbert Cc: Jason Gunthorpe, vishnu.dasa, leon, bcm-kernel-feedback-list, linux-rdma, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 893 bytes --] On Mon, Mar 3, 2025 at 6:42 PM Dr. David Alan Gilbert <linux@treblig.org> wrote: > * Jason Gunthorpe (jgg@ziepe.ca) wrote: > > On Sun, Mar 02, 2025 at 10:05:11PM +0000, Dr. David Alan Gilbert wrote: > > > Hi, > > > I noticed that pvrdma_modify_device() in > > > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c > > > isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ? > > > > > > (I've not got VMWare anywhere to try it on, and don't know the innards > > > of RDMA drivers; so can't really test it). > > Hi Jason, > Thanks for the reply, > > > Seems probably right > > > > But at this point I'd just delete it unless pvrdma maintainers say > > otherwise in the next week > > OK, lets see if they wake up. > > Dave Thanks David for bringing this up. You're right, it looks like we never wired it up to pvrdma_dev_ops. Feel free to remove it. [-- Attachment #1.2: Type: text/html, Size: 1225 bytes --] [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 5430 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Unwired pvrdma_modify_device ? 2025-03-04 13:25 ` Bryan Tan @ 2025-03-04 15:39 ` Dr. David Alan Gilbert 2025-03-04 21:58 ` Dr. David Alan Gilbert 0 siblings, 1 reply; 6+ messages in thread From: Dr. David Alan Gilbert @ 2025-03-04 15:39 UTC (permalink / raw) To: Bryan Tan Cc: Jason Gunthorpe, vishnu.dasa, leon, bcm-kernel-feedback-list, linux-rdma, linux-kernel * Bryan Tan (bryan-bt.tan@broadcom.com) wrote: > On Mon, Mar 3, 2025 at 6:42 PM Dr. David Alan Gilbert <linux@treblig.org> > wrote: > > * Jason Gunthorpe (jgg@ziepe.ca) wrote: > > > On Sun, Mar 02, 2025 at 10:05:11PM +0000, Dr. David Alan Gilbert wrote: > > > > Hi, > > > > I noticed that pvrdma_modify_device() in > > > > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c > > > > isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ? > > > > > > > > (I've not got VMWare anywhere to try it on, and don't know the innards > > > > of RDMA drivers; so can't really test it). > > > > Hi Jason, > > Thanks for the reply, > > > > > Seems probably right > > > > > > But at this point I'd just delete it unless pvrdma maintainers say > > > otherwise in the next week > > > > OK, lets see if they wake up. > > > > Dave > > Thanks David for bringing this up. You're right, it looks like we > never wired it up to pvrdma_dev_ops. Feel free to remove it. Hi Bryan, Thanks for the reply - OK, I'll send a patch later to remove it. Dave -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Unwired pvrdma_modify_device ? 2025-03-04 15:39 ` Dr. David Alan Gilbert @ 2025-03-04 21:58 ` Dr. David Alan Gilbert 0 siblings, 0 replies; 6+ messages in thread From: Dr. David Alan Gilbert @ 2025-03-04 21:58 UTC (permalink / raw) To: Bryan Tan Cc: Jason Gunthorpe, vishnu.dasa, leon, bcm-kernel-feedback-list, linux-rdma, linux-kernel * Dr. David Alan Gilbert (linux@treblig.org) wrote: > * Bryan Tan (bryan-bt.tan@broadcom.com) wrote: > > On Mon, Mar 3, 2025 at 6:42 PM Dr. David Alan Gilbert <linux@treblig.org> > > wrote: > > > * Jason Gunthorpe (jgg@ziepe.ca) wrote: > > > > On Sun, Mar 02, 2025 at 10:05:11PM +0000, Dr. David Alan Gilbert wrote: > > > > > Hi, > > > > > I noticed that pvrdma_modify_device() in > > > > > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c > > > > > isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ? > > > > > > > > > > (I've not got VMWare anywhere to try it on, and don't know the innards > > > > > of RDMA drivers; so can't really test it). > > > > > > Hi Jason, > > > Thanks for the reply, > > > > > > > Seems probably right > > > > > > > > But at this point I'd just delete it unless pvrdma maintainers say > > > > otherwise in the next week > > > > > > OK, lets see if they wake up. > > > > > > Dave > > > > Thanks David for bringing this up. You're right, it looks like we > > never wired it up to pvrdma_dev_ops. Feel free to remove it. > > Hi Bryan, > Thanks for the reply - OK, I'll send a patch later to remove it. Just sent, See 20250304215637.68559-1-linux@treblig.org Dave > Dave > > -- > -----Open up your eyes, open up your mind, open up your code ------- > / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ > \ dave @ treblig.org | | In Hex / > \ _________________________|_____ http://www.treblig.org |_______/ > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/ ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-03-04 21:58 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-03-02 22:05 Unwired pvrdma_modify_device ? Dr. David Alan Gilbert 2025-03-03 18:26 ` Jason Gunthorpe 2025-03-03 18:42 ` Dr. David Alan Gilbert 2025-03-04 13:25 ` Bryan Tan 2025-03-04 15:39 ` Dr. David Alan Gilbert 2025-03-04 21:58 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox