From: Danilo Krummrich <dakr@kernel.org>
To: phasta@kernel.org
Cc: "Matthew Brost" <matthew.brost@intel.com>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/sched: Fix outdated comments referencing thread
Date: Mon, 3 Mar 2025 16:53:05 +0100 [thread overview]
Message-ID: <Z8XQYTXOktHKaOY1@pollux> (raw)
In-Reply-To: <d7308a0c8ea0fa95f0d4a93364e72e4a1eb15587.camel@mailbox.org>
On Mon, Mar 03, 2025 at 04:48:36PM +0100, Philipp Stanner wrote:
> On Tue, 2025-02-25 at 14:53 +0100, Danilo Krummrich wrote:
> > On Tue, Feb 25, 2025 at 02:13:32PM +0100, Philipp Stanner wrote:
>
> > > - * is parked at which point it's safe.
> > > + * drm_sched_cleanup_jobs. It will be reinserted
> > > back after the
> > > + * scheduler's workqueues are stopped at which
> > > point it's safe.
> >
> > You don't know whether the workqueues are "stopped". I think you want
> > to say
> > that run_job / free_job work isn't scheduled or running.
>
> How about "after the scheduler's work items have been cancelled"?
Sure, that's fine too. But be aware that you may have to change this wording in
case another (unrelated) work item is gets added to the scheduler for some
reason.
prev parent reply other threads:[~2025-03-03 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 13:13 [PATCH 1/2] drm/sched: Fix outdated comments referencing thread Philipp Stanner
2025-02-25 13:13 ` [PATCH 2/2] drm/sched: Remove kthread header Philipp Stanner
2025-02-25 13:55 ` Danilo Krummrich
2025-02-25 13:53 ` [PATCH 1/2] drm/sched: Fix outdated comments referencing thread Danilo Krummrich
2025-03-03 15:48 ` Philipp Stanner
2025-03-03 15:53 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8XQYTXOktHKaOY1@pollux \
--to=dakr@kernel.org \
--cc=airlied@gmail.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=phasta@kernel.org \
--cc=simona@ffwll.ch \
--cc=tvrtko.ursulin@igalia.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox