From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B22F1EE00D for ; Mon, 3 Mar 2025 22:21:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741040464; cv=none; b=p5C9rCJ7fLxQR9UUck1IX4hTYtciZZt20zGvm+ZtJTF1GmQw++d9AJHSQQy1wCyRO3Ng/u4zC1yQumexhMwtD+723xBol4gJZXN/kozzw6hTLIjLB7N7gsC8YdTHBS0mJNiCZb1NgOGCUllEbQhbBUTurt7q6HVWOez0ZDYj1PQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741040464; c=relaxed/simple; bh=8lSPo+KIIq2qYRr/9d3MJdKf0ce1XIDRY2s2HaDhhXs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K5N8o+7EfaXjodaiZmUQpYwWzI+yTZC24gcjDt2GuMo++xeUt6tmgxdBbO7mxv1AgMe+f/HJYfktBcxFu/EEx2y3wI/+QRNq0wEv8lZFjKE6UPMX75qKNQ0jyioKHI66ZitDI+h8KCfM15vDggBSxFQhoDgvtJnzjzVfFRU0TyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OA80H5t3; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OA80H5t3" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-223a0da61easo56975ad.0 for ; Mon, 03 Mar 2025 14:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741040462; x=1741645262; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TIPE161XE6h+XbpKbqRdjbwFF+hmkeZmLDbhV/M2UTU=; b=OA80H5t3RtNNuYvjlw0//qqL+sgjc7wPnLNGw/yNi52z072O13Tf2MSnjo30V8Kg4V Qewn+EV+ncE+yhSE4ywBHWeaaGXO0F+4W/wL0rU2FxRZ0gLeNMYO8bKB3llmU6E4+ZsK a9fJ6tiTN5SSWkCgXCYg3/RbxpTust+fSeYn50usD2WEi+3s5FDVBF+RUJzqgV8o2V1x qkD96rac4IqwmDJEn9RaHFaRFYbym1JkvufH66xJd4HksBDQU3vVKCDYuLm8TosQ2UQP LL174c+nrOMgn+UwzfxpsMJ97055SaNXfw96i8rREDzt+ZFOgih2YRAO6OI+dl4Lsmuf BeSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741040462; x=1741645262; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TIPE161XE6h+XbpKbqRdjbwFF+hmkeZmLDbhV/M2UTU=; b=Ru1pzHl6mW6STLL1emM632aTgqwc3LWsseuJL0KCBs+I6mR9znP0h0MxMGn0Vc4j9A M+R8NJ7TWRGCtSM2WJiNKlhHzw7lqpKYMefQtglbQDi43A2KPyFNZPZQrBYxbYdUM+gd w708iDMXxxFC4RdSYVSDrG8iYPciySbj1cjCAuHqCkSvBDUWINiVtVPYVy6LRF00ZIZd RZ0FF0/cg7mAhuKOdLt08T6F/33Lb0pGxNTnEQYx7bq+To5lOlXALqhfDr9YGlvYBnv8 5gDzuZo+Xz67NQSKcyM1igwRBcxHvVxWbsz/gm1AErgZdarDzdViKLCCDL2b11xKF0wi cstw== X-Forwarded-Encrypted: i=1; AJvYcCULOOiOIHV7wfjS8AMfU0Kr2j2czB+AGVTAAyE4LMtpO2F/p0AlG1uHyOVfbuwVMJUZfYW40QCgNIhaFI0=@vger.kernel.org X-Gm-Message-State: AOJu0YwiysAfEe0ultH9XJch/uiIHdc6IQYjsAjE8KkLbJt/p/7eh9aJ L/FSuFVb9y3iJ3jkgOiGlScM2D4GYJrtiDLs96HcTOCcmCSX4cwXmxIQh1IXOw== X-Gm-Gg: ASbGncvKPTAUiiFAfu30XFlcN61rAoSJeHTw3KEwhtUAtBuQEnSs4etvD7KgjIjWRi1 npn/o0kDX9yd1benHeOPHq7jSre2JwtRo6Vu/F6DDdxmv1KvaVBstG/by6nWaaB17MzTuilmRfX DBK0WdbxgS38x68uwO1VvkXRFfgAGnULet/MmfXyjm8W0TtEjvbTn4CMJyxfa4yV0PDZNmK/eDK BUDSowEsOt7R8g+rxOYSotJJI4zYE7V3SlxS1ox9xcQDi/JqyNdu15pS6Ct04TK6R1R8909ghF8 KsvyqVKKH2MS63ns3tVinRSLJXK1Vc1x4Lw6SoPIEvIjgVStUheJFXLDZ82PV+J8IAqAHMNmFxM /TjIeG2o= X-Google-Smtp-Source: AGHT+IHFnd6jZyLm3rBh852SMedzrz4n0Ml2vmv/2ld5Rglar/I+rjdCt1PE6PBirI1AmbiL/BJNuA== X-Received: by 2002:a17:902:e546:b0:21f:3e29:9cd4 with SMTP id d9443c01a7336-223d9e656cfmr770325ad.20.1741040462117; Mon, 03 Mar 2025 14:21:02 -0800 (PST) Received: from google.com (147.141.16.34.bc.googleusercontent.com. [34.16.141.147]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-aee7dedd22esm7402504a12.63.2025.03.03.14.21.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 14:21:01 -0800 (PST) Date: Mon, 3 Mar 2025 22:20:55 +0000 From: Peilin Ye To: Alexei Starovoitov Cc: bpf , linux-arm-kernel , bpf@ietf.org, Alexei Starovoitov , Xu Kuohai , Eduard Zingerman , David Vernet , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Jonathan Corbet , "Paul E. McKenney" , Puranjay Mohan , Ilya Leoshkevich , Heiko Carstens , Vasily Gorbik , Catalin Marinas , Will Deacon , Quentin Monnet , Mykola Lysenko , Shuah Khan , Ihor Solodrai , Yingchi Long , Josh Don , Barret Rhoden , Neel Natu , Benjamin Segall , LKML Subject: Re: [PATCH bpf-next v4 03/10] bpf/verifier: Factor out check_load_mem() and check_store_reg() Message-ID: References: <8b39c94eac2bb7389ff12392ca666f939124ec4f.1740978603.git.yepeilin@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 03, 2025 at 10:52:08AM -0800, Alexei Starovoitov wrote: > > Extract BPF_LDX and most non-ATOMIC BPF_STX instruction handling logic > > in do_check() into helper functions to be used later. While we are > > here, make that comment about "reserved fields" more specific. > > > > Suggested-by: Eduard Zingerman > > Acked-by: Eduard Zingerman > > Signed-off-by: Peilin Ye > > Applied the first 3 patches. Thanks! I'll fix that build issue for 32-bit arches, then send remaining patches (except v4 10/10) as v5. Cheers, Peilin Ye