From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 755AB1FCF63 for ; Tue, 4 Mar 2025 08:41:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741077705; cv=none; b=SMtKePXJrUGHJZwSeDD8rmBP9a6HrjysTyTjvS+iViuczuGMfwpvRgkdhqBj8v/CLs3kITvFyNfEfUATIqLIIMUZ8OjUvJGuNYwRHyAxKrNLTrzQ4UZrNlLFRHTYh8/0hdzUslj+TS0VYrLxnm19zbCLg4ClnpMPxFEA/yQXeUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741077705; c=relaxed/simple; bh=dQMWqa7bqGUsuYvK1/Ia2Th2yYYxZTfZ4zTTgbD3dM8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iXaqOhTd2LGr77k0i6inUUL2wtd64yk1WGxIvvbwiPt9p/iMBJyMjnwoZhVFgT+QmbGijdnJt4UxLsLoSnlklLWTDoaHoutjTQtGrQsRux4EFGsUkFp0YCHlBPdajyzXBrSel4qLjxotblY+862Pf7d7V6U6LeOTmS113z/EwcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mETPgI23; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mETPgI23" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-abf4b376f2fso499682466b.3 for ; Tue, 04 Mar 2025 00:41:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741077701; x=1741682501; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=56LRZhimeVf0548v2DjrELpnYIUuGBcJG2m3Hu8yBtw=; b=mETPgI23iMZxrX7GFlSZRwwi7jXMWbtYR4M3vRphfBCECl58WfB81Rx9vB6ka0K3t2 L/LFUswCMPP7zQsX2+qYYyvXJlIFe0+96ZuZB8QIMW20xuVvEn+22VTPPwE1ykFp8UET QugvwKbKib9yg5nXJnasC8WWRhvPtotg0o5LLcT2L7QDr4n/HgpZlFourgonBQLEcyHz 41qc2oNbkw5hA/ZW/Afs2EeB6X3vq1X7y8SunsRQFmSsV8LSHWEd8ogu72H0yiamGsVk 8v6oVEFyYisedodPQ4g7etioVcdXT7oFxC3SNWy+UxjDNYvR6ytzHziVV9qqpUhDN4/i ShJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741077701; x=1741682501; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=56LRZhimeVf0548v2DjrELpnYIUuGBcJG2m3Hu8yBtw=; b=EGM3blyguwXwzZiKUa8HjvEO/YT85KxCCez8oJsVMdO9FpU8Hpe2VuHCbDOypiCw4U 1J+4Nl48r3Vw3XN8P6V3GSTW0MfGHJcVa5MgMOfMBq2fC3U4PtPMYYpq2CQyguYBDa/P CfYQbi8UjPGKySy6iHLucQgcufLVExGdrItOdyGTjV9NQnCfFFYNhNMUwkcn3M8TbMyK XP5QKWDEaL9NEkeoZCUW7V9Hrt9FHIdouWvtUTeh5/kzydclMfIP0zKV0LQLJIE8fGVh tw3LiOkP/8uWS1WMyC8Cy4XDPkX6uC+dm42TgP2/37KHNsMYHPIXxT6Y94tSW+6EZLBM HJkQ== X-Forwarded-Encrypted: i=1; AJvYcCUUn/tmJbBaPtI6o7bBNSZmHrRlyw2LayjTxqAoEoU72/ed84qILutk7wFzBcNweXJ6dEnfFsF4sPt0+hE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+7iOA6pjcVA4nAePdE2rHGBeZzJ+3FhTT8Bvo8p7PF0+i/cIp UCBHv1b+T2m/EYh2hTlsdfvPJhQCLpF8tJ+yKbJumugn+xzBQAEJa9wIhst2xsM= X-Gm-Gg: ASbGncsMauYXjaNJnPkBTn+iWPWYBSjYvYzETOpgsVcANNYj2uzcZZbYQpWJ5mc1AW/ hn+2E6plrxV9U8qKHfTN/50ZCCpC+Mm6MOpYqkjbOxeUKOdQ8oAR4ddDJNOQvWhSw83NyY16V8/ Xpg9a5SXkgARQpd700MY7WNex98KfVnMwulnFUnBDEwR4J+fgEGQ+QsWwAjRr7BCp2e1R+8m/WP MKPJbHOkbMIkrwp5pHI4nNpW2o90yXiP/20GcQyI+nSgg+6fW03Fy5XM3u/xEn/7YhUOXK9h62X ddeJm4hZCmwN7KoFUpvbBxcknutkknbjYeDBgiZnWQ== X-Google-Smtp-Source: AGHT+IFFHM/nljeEtmfpwAYQ5fCe3mzYlZ/kbhPchbUbj2wuqBNp/7U42a+daD7qurHBY27yA6v3Yg== X-Received: by 2002:a17:907:7d89:b0:abf:7832:bf5 with SMTP id a640c23a62f3a-abf783244f6mr732543466b.34.1741077700633; Tue, 04 Mar 2025 00:41:40 -0800 (PST) Received: from linaro.org ([62.231.96.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf529feacfsm557445466b.153.2025.03.04.00.41.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 00:41:40 -0800 (PST) Date: Tue, 4 Mar 2025 10:41:38 +0200 From: Abel Vesa To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Lee Jones , Pavel Machek , Anjelique Melendez , Kamal Wadhwa , Jishnu Prakash , Bjorn Andersson , Konrad Dybcio , Johan Hovold , Sebastian Reichel , Pavel Machek , linux-leds@vger.kernel.org, linux-pwm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 0/3] leds: rgb: leds-qcom-lpg: PWM fixes Message-ID: References: <20250303-leds-qcom-lpg-fix-max-pwm-on-hi-res-v3-0-62703c0ab76a@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 25-03-04 07:29:46, Uwe Kleine-König wrote: > Hello, > > On Mon, Mar 03, 2025 at 01:52:49PM +0200, Abel Vesa wrote: > > The PWM allow configuring the PWM resolution from 8 bits PWM > > values up to 15 bits values, for the Hi-Res PWMs, and then either > > 6-bit or 9-bit for the normal PWMs. The current implementation loops > > through all possible resolutions (PWM sizes), for the PWM subtype, on top > > of the already existing process of determining the prediv, exponent and > > refclk. > > > > The first and second issues are related to capping the computed PWM > > value. > > I just took a very quick look. I'd say squash the first and second patch > into a single one. Splitting a change that fixes the same issue in the > two branches of an if condition has no benefit. Actually, the first two patches fix different commits. The first patch fixes a commit that is only in linux-next for now, while the second patch fixes a commit that has been merged in 6.4. So they need to be separate patches. > > Other than that this patch set would also benefit from what I wrote in > the review of the other patch you send: Please mention a request where > the result becomes wrong. This considerably simplifies understanding > your changes. Sure. Will describe the 5ms vs 4.26ms period scenario. Hope that's OK. > > Thanks > Uwe Thanks for reviewing, Abel