Re: [PATCH v3 0/3] leds: rgb: leds-qcom-lpg: PWM fixes

Uwe Kleine-König
2025-03-04T06:29:50Z

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

Hello,

On Mon, Mar 03, 2025 at 01:52:49PM +0200, Abel Vesa wrote:
> The PWM allow configuring the PWM resolution from 8 bits PWM
> values up to 15 bits values, for the Hi-Res PWMs, and then either
> 6-bit or 9-bit for the normal PWMs. The current implementation loops
> through all possible resolutions (PWM sizes), for the PWM subtype, on top
> of the already existing process of determining the prediv, exponent and
> refclk.
>
> The first and second issues are related to capping the computed PWM
> value.

I just took a very quick look. I'd say squash the first and second patch
into a single one. Splitting a change that fixes the same issue in the
two branches of an if condition has no benefit.

Other than that this patch set would also benefit from what I wrote in
the review of the other patch you send: Please mention a request where
the result becomes wrong. This considerably simplifies understanding
your changes.

Thanks
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]