From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAE7B2066EE; Wed, 5 Mar 2025 10:30:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741170638; cv=none; b=WoRTl7KiLcOOUm5H3IKsMr8VhaJgBcJBFzhNKHNAOb8qstej79B0dz0M1sOBECTbe4tzSE3iumS1v5j54RX91N1KrSPr7DiCKFVQk8oB8W4/3byuZS2HBhXKxjScte/oPFxfX8m1A3Qqgl20KT4IAwLr2zZoi6P0v60gwiXhGng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741170638; c=relaxed/simple; bh=H3pe/p2yHg6JN3GTrX0Rfqp5BVs5ufrKO6v+86OK34g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eYvrKByFJNjoXoX/XhVO0hSoz11r848XRKw9vJCzYlysR2aFScqm0Rxrd+2FcPwnJCn827rATNRuJVvbTwnJybktt6FOPH9zzOqrlTKOVr/4w97r7xbuolTitl3dhLCfxbnMsdeft1Y0u3bX2vsqcgK3NHl9SfJRPWs82mzwY0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: 022NGo0+RKyvi9k787RnTQ== X-CSE-MsgGUID: jM+6tcl0Qwqm5wNSSiJHeA== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="64567008" X-IronPort-AV: E=Sophos;i="6.14,222,1736841600"; d="scan'208";a="64567008" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 02:30:36 -0800 X-CSE-ConnectionGUID: WDkYJmSHT0OrYH3RzlgbQw== X-CSE-MsgGUID: ttOP2cH/SDKXIxbe3IsO4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="122783306" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 02:30:26 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tpm18-0000000HNpF-00A7; Wed, 05 Mar 2025 12:30:22 +0200 Date: Wed, 5 Mar 2025 12:30:21 +0200 From: Andy Shevchenko To: George Cherian Cc: linux@roeck-us.net, wim@linux-watchdog.org, jwerner@chromium.org, evanbenn@chromium.org, kabel@kernel.org, krzk@kernel.org, mazziesaccount@gmail.com, thomas.richard@bootlin.com, lma@chromium.org, bleung@chromium.org, support.opensource@diasemi.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, paul@crapouillou.net, alexander.usyskin@intel.com, andreas.werner@men.de, daniel@thingy.jp, romain.perier@gmail.com, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, naveen@kernel.org, mwalle@kernel.org, xingyu.wu@starfivetech.com, ziv.xu@starfivetech.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, openbmc@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, patches@opensource.cirrus.com Subject: Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP Message-ID: References: <20250305101025.2279951-1-george.cherian@marvell.com> <20250305101025.2279951-2-george.cherian@marvell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250305101025.2279951-2-george.cherian@marvell.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Mar 05, 2025 at 10:10:24AM +0000, George Cherian wrote: > A new option flag is added to watchdog_info. This helps the watchdog > core to check whether stop functions would sleep or not. > The option flags of individual drivers are also updated accordingly. ... > .options = WDIOF_SETTIMEOUT | > WDIOF_MAGICCLOSE | > - WDIOF_KEEPALIVEPING, > + WDIOF_KEEPALIVEPING | > + WDIOF_STOP_MAYSLEEP, You may heavily reduce this change if you squeeze the new option just before the last one. Currently it's a lot of unneeded churn that makes review a bit harder (each needs to be carefully checked for the correctness). -- With Best Regards, Andy Shevchenko