From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F3BB207A0E; Wed, 5 Mar 2025 10:33:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741170838; cv=none; b=pm2fdg0S7NBLe5bachI8ctXwF3fNAjGGYGx1pcuGe05PE+dmn+YWNoRMV9/MAutNLxnTBAneaXhKP7pfvqtD5r1AlbBSRtXUMJKxRO/GDG8LUVeTYKagEXtqzgiJn1uxq7mwNGBNLqULmPz6icny30bGIvR+2ciHb3s/N7RX2ME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741170838; c=relaxed/simple; bh=/kfliGAoBPvG2knwQZdrlMxpuZZfEtlJZ3KKuBQ/FTY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=plDC9sMDOCHCjbPXb7pXVBxnwonkWmKNNqQf2aV386GgzmjUpWILRupi+EzjZ2owNdMpwKWbWX2KhyfEgtBTJBeLV60k88jbvwd1XkeXmvJi2PgzvtWXiWLHWM63lOHCoY5uuXQakwro1zzSWVEQMHZ5X6H7f3H087BdamQk7pM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: t4huneS6T/yGNZN0mL9lRQ== X-CSE-MsgGUID: pYN75pXjStKsuePUmcp1lA== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="44936599" X-IronPort-AV: E=Sophos;i="6.14,222,1736841600"; d="scan'208";a="44936599" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 02:33:56 -0800 X-CSE-ConnectionGUID: Pmo02+QiRyuCyBTsLyBQKA== X-CSE-MsgGUID: +3/qaz49Qz6WtsiJJYV/Ng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,222,1736841600"; d="scan'208";a="123579370" Received: from smile.fi.intel.com ([10.237.72.58]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 02:33:46 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tpm4L-0000000HNsf-1gjT; Wed, 05 Mar 2025 12:33:41 +0200 Date: Wed, 5 Mar 2025 12:33:41 +0200 From: Andy Shevchenko To: George Cherian Cc: linux@roeck-us.net, wim@linux-watchdog.org, jwerner@chromium.org, evanbenn@chromium.org, kabel@kernel.org, krzk@kernel.org, mazziesaccount@gmail.com, thomas.richard@bootlin.com, lma@chromium.org, bleung@chromium.org, support.opensource@diasemi.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, paul@crapouillou.net, alexander.usyskin@intel.com, andreas.werner@men.de, daniel@thingy.jp, romain.perier@gmail.com, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, naveen@kernel.org, mwalle@kernel.org, xingyu.wu@starfivetech.com, ziv.xu@starfivetech.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, openbmc@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, patches@opensource.cirrus.com Subject: Re: [PATCH v4 2/2] drivers: watchdog: Add support for panic notifier callback Message-ID: References: <20250305101025.2279951-1-george.cherian@marvell.com> <20250305101025.2279951-3-george.cherian@marvell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250305101025.2279951-3-george.cherian@marvell.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Mar 05, 2025 at 10:10:25AM +0000, George Cherian wrote: > Watchdog is not turned off in kernel panic situation. > In certain systems this might prevent the successful loading > of kdump kernel. The kdump kernel might hit a watchdog reset > while it is booting. > > To avoid such scenarios add a panic notifier call back function > which can stop the watchdog. This provision can be enabled by > passing watchdog.stop_on_panic=1 via kernel command-line parameter. ... First of all, do we really need a new module parameter for that? Why can't it be done automatically if kdump is expected? > +static bool stop_on_panic; > +module_param(stop_on_panic, bool, 0444); > +MODULE_PARM_DESC(stop_on_panic, "Stop watchdogs on panic (0=keep watching, 1=stop)"); + blank line. Also I do not see the documentation update. Where is it lost? > /* -- With Best Regards, Andy Shevchenko