From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97906199B8 for ; Thu, 6 Mar 2025 15:17:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741274268; cv=none; b=suJ09KRI73yfGxjZWwUDfGSRi6vstMMNg+jVqfcJp/bzMFNHzZTJND2EuMEdKbBsBIi5XrUbXAxYI+nBgy7/pVEZRWeM0MtF5hhG/UaRHRV377Pz5mwZERJ5U+6K7deCXgCC9Fu+O4VmAaHpaM7UKbWpVMFidYDR20+FpVQBnKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741274268; c=relaxed/simple; bh=dr9CiNvfAd0YB723EuYpxVXaiZlaCdym/85jxaQlXRI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cilLi9blZVvOosoJwKTMWtOasbAq620PGfYMz0EMpO5nLlWD4wAe2dzPUxKsvuJzXnf5SBTDcXDb+6+fp/nx31QrJJNYxPlw7i4ynxhgpeBgEMlJFzN+gjqGGJOcFyS8SK9crLyLuQ+pakX+y9ZLsbhl+m5v9QcSmWpDDcv6PAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=IT/u8WMN; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="IT/u8WMN" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=Content-Type:MIME-Version:Message-ID:Subject:From:Date:From :Subject; bh=0unTMUYP4YC5gPzX5umX6gS2Jm7fnTaK+gi9Szyd/LQ=; b=IT/u8WMN+Jkxoibt wB2Dlxk/VkuakTm47nBE9LsuZU7qdsiS0jN2ywJ0qMY+r6yJGl+npMBpBo9GZS1bZcncavQTF2wsi 2AI3JwU1vPrhjQBW4UqQDMBpiOjLqZF1zRazyNe6dwZvmCEzdHV/SHcf3z5VoCNWXhGcpNMcL2HYD /7O7IZ/2ihm1dW3XKhHsxAak2pExGZ0FObTOB50aIkiVOrdIfWqUHmzdwE8Ol2C3icI2bJvKdKP4x Eyx47tV5vxB+pkBIensGzBi2vd6PU1HHSsEdVC/lQU4j0a8l1zkOllO5+yWjSuDqh7OyuBNaqsKKH Nvv4ulN/Ffy3gr5Q9g==; Received: from dg by mx.treblig.org with local (Exim 4.96) (envelope-from ) id 1tqCyZ-0038rI-1d; Thu, 06 Mar 2025 15:17:31 +0000 Date: Thu, 6 Mar 2025 15:17:31 +0000 From: "Dr. David Alan Gilbert" To: Patrik Jakobsson Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/gma500: Remove unused mrst_helper_funcs Message-ID: References: <20250201011434.453879-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/6.1.0-21-amd64 (x86_64) X-Uptime: 15:16:30 up 302 days, 2:30, 1 user, load average: 0.00, 0.01, 0.00 User-Agent: Mutt/2.2.12 (2023-09-09) * Patrik Jakobsson (patrik.r.jakobsson@gmail.com) wrote: > On Sat, Feb 1, 2025 at 2:14 AM wrote: > > > > From: "Dr. David Alan Gilbert" > > > > The mrst_helper_funcs const was added in 2013 by > > commit ac6113ebb70d ("drm/gma500/mrst: Add SDVO clock calculation") > > and commented as 'Not used yet'. > > > > It's not been used since, so remove it. Hi Patrik, > You talk about mrst_helper_funcs but the patch removes > mrst_clock_funcs. I assume this is not intentional. Oops! Thanks for spotting that, I'll send a v2 fixing the commit message; I think I was intending to write something like 'the helper functions it references are still used elsewhere.' v2 coming up soon. Dave > -Patrik > > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > drivers/gpu/drm/gma500/oaktrail_crtc.c | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c > > index de8ccfe9890f..ea9b41af0867 100644 > > --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c > > +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c > > @@ -658,10 +658,3 @@ const struct drm_crtc_helper_funcs oaktrail_helper_funcs = { > > .prepare = gma_crtc_prepare, > > .commit = gma_crtc_commit, > > }; > > - > > -/* Not used yet */ > > -const struct gma_clock_funcs mrst_clock_funcs = { > > - .clock = mrst_lvds_clock, > > - .limit = mrst_limit, > > - .pll_is_valid = gma_pll_is_valid, > > -}; > > -- > > 2.48.1 > > > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/