Re: [PATCH v5 3/3] printf: implicate test line in failure messages

Tamir Duberstein
2025-03-07T16:25:14Z

On Fri, Mar 7, 2025 at 11:23 AM Petr Mladek <pmladek@suse.com> wrote:
>
> On Fri 2025-02-21 15:34:32, Tamir Duberstein wrote:
> > This improves the failure output by pointing to the failing line at the
> > top level of the test, e.g.:
> > # test_number: EXPECTATION FAILED at lib/printf_kunit.c:103
> > lib/printf_kunit.c:167: vsnprintf(buf, 256, "%#-12x", ...) wrote '0x1234abcd ', expected '0x1234abce '
> > # test_number: EXPECTATION FAILED at lib/printf_kunit.c:142
> > lib/printf_kunit.c:167: kvasprintf(..., "%#-12x", ...) returned '0x1234abcd ', expected '0x1234abce '
> >
> > Signed-off-by: Tamir Duberstein <tamird@gmail.com>
>
> Just for record. I like this improvement. But I am going to wait for the
> next version of the patchset which is going to add back the trailing '\n'.

👍