Re: [PATCH v5 2/7] bits: introduce fixed-type genmasks

Andy Shevchenko
2025-03-06T17:53:50Z

On Fri, Mar 07, 2025 at 01:08:01AM +0900, Vincent Mailhol wrote:
> On 06/03/2025 à 22:08, Andy Shevchenko wrote:
> > On Thu, Mar 06, 2025 at 08:29:53PM +0900, Vincent Mailhol via B4 Relay wrote:

...

> Does this mean I get your Reviewed-by tag? Or will you wait the v6 to
> formally give it?

I'll wait for v6.

> > but just to be sure: you prepared your series using histogram
> > diff algo, right?
>
> No, I never used the histogram diff. My git config is extremely boring.
> Mostly vanilla.
>
> I remember that Linus even commented on this:
>
> https://lore.kernel.org/all/CAHk-=wiUxm-NZ1si8dXWVTTJ9n3c+1SRTC0V+Lk7hOE4bDVwJQ@mail.gmail.com/
>
> But he made it clear this was *not* a requirement, so I just left the
> diff algorithm to the default. Or did I miss any communication that
> contributors should now use histogram diff?

Use your common sense, i.e. look at the result and evaluate which one is more
readable. My guts are telling me that histogram will be slightly better here.

> Regardless, I do not mind activating it. I just did a:
>
> git config diff.algorithm histogram
>
> The v6 will have histogram diffs.

--
With Best Regards,
Andy Shevchenko