From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D93713635B for ; Thu, 6 Mar 2025 16:55:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741280119; cv=none; b=FnacHWMRGkwlnZvKfOoAzFwGth5yVKzsw+1PgM8mj7E+k0zF1sW7m+bh4T9kHG1b3kiODSKe0wfXQO0uFHY73ofg83pTK4zoLhq7oAzfpQYnVJqqvSGBgutGRG5Rfq+LhOLm19vVV+9RkF4cNqsz5G3v+pSSCdOTCBrVfadGmlg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741280119; c=relaxed/simple; bh=ojDLRfmuqq9GPR5jEUbYNGGbiERxN/yA2YCWiVfKxJQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EZXd0DDXzPSZvZzBpABXIaSWgc7T2P+F5y/8o/W2C3shRtAAL1WTQ4+79z4D4NZUTt5hZ5tyQPICArc7R5c7tfYsGgT5h5oR2X5c89lbWSFr63vwpk3IgYr5WjVW5z1r+Nv4PA6IuOi+ac6W9p3Q8zo17+JnNW4UFmm9K3RWj3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=vQsIxCqt; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="vQsIxCqt" Date: Thu, 6 Mar 2025 16:55:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741280112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kwhx/mtOi1GHi7BWSEe20K0H0IJsKkOByjdFjZj3bKc=; b=vQsIxCqtKLzZDN2FoDbwBZ2U/BVPqjwidfkrceSl4A798NuUB19lgu1wZEi7kwHPakRhDP ssQA/ydZeQ3uErvGo9p7CSJ4b0V9D+rGJbDkfxpWmJpixhunt341epOTV0C+2JPSqobLkz EL6msC+6vtKG1sarEevBM/MFeofyaPM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Herbert Xu , Sergey Senozhatsky Cc: Andrew Morton , Johannes Weiner , Nhat Pham , Chengming Zhou , Minchan Kim , Sergey Senozhatsky , Thomas Gleixner , Peter Zijlstra , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable 3/5] mm: zpool: Remove object mapping APIs Message-ID: References: <20250305061134.4105762-1-yosry.ahmed@linux.dev> <20250305061134.4105762-4-yosry.ahmed@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Thu, Mar 06, 2025 at 12:19:19PM +0800, Herbert Xu wrote: > On Thu, Mar 06, 2025 at 09:48:58AM +0800, Herbert Xu wrote: > > > > This patch breaks zbud and z3fold because they haven't been converted > > to the new interface. > > I've rebased my zswap SG patch on top of your series. I've removed > all the mapping code from zpool/zsmalloc and pushed it out to zram > instead. > > This patch depends on a new memcpy_sglist function which I've just > posted a patch for: > > https://patchwork.kernel.org/project/linux-crypto/patch/Z8kXhLb681E_FLzs@gondor.apana.org.au/ > > From a77ee529b831e7e606ed2a5b723b74ce234a3915 Mon Sep 17 00:00:00 2001 > From: Herbert Xu > Date: Thu, 6 Mar 2025 12:13:58 +0800 > Subject: [PATCH] mm: zswap: Give non-linear objects to Crypto API > > Instead of copying non-linear objects into a buffer, use the > scatterlist to give them directly to the Crypto API. > > Signed-off-by: Herbert Xu The zswap and zsmalloc look good and the code is simpler. I am fine with this approach if Sergey is fine with it, although I wonder if we should update Sergey's patches in mm-unstable do this directly. Currently we are switching from mapping APIs to read/write APIs, and then quickly to the pinning APIs. The history will be confusing. Sergey, do you prefer if we keep things as-is, or if you update your series to incorporate Herbert's changes for zsmalloc/zram, then I can update my series to incorporate the changes in zswap? We can also combine the series into a single updated one with zsmalloc/zram/zswap changes. Let me know what you prefer.