From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB52525B671 for ; Thu, 6 Mar 2025 17:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741283632; cv=none; b=VKV6IBR3jgbP3izIy5dcLrNy9xbGsLcB2LzMBFH6Ck57ChfWUpF2vN/Cw6n2df5YwMdR1ZsDOiFrFu8SRtRVVwNOOw1craTvJZx1j6+c7hI2N6tdNQvX9O3DqieQAA+uDxUNfOb00LWv+1nAITPaTE+atyMYCGOQl9Is7yowhQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741283632; c=relaxed/simple; bh=TsDBzmg+/rLwfKQ/+P27CYwnhvUD4cy1XnVraIMWiyw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ui9LjTyHTnDeuqiEX0Bw3TPW2zm+XlYGRv6EzCNdkgE9bNt5RPG1qfMZTO3FvxCsoFC1R/V1rakZ3GjaDkhByYPyAF9uF/iyYcM2DTdBbAUpi+yefO7czMYf0bTpv11BW10a4nK1hWaBemYRChterehXdsGvZvAf5kWK4y+pvqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=k9tOjDmo; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="k9tOjDmo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741283631; x=1772819631; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=TsDBzmg+/rLwfKQ/+P27CYwnhvUD4cy1XnVraIMWiyw=; b=k9tOjDmos0HJvnDAdAE9P3d4t9MhmGSx4DvVksMDlxkpbfaJrK+qkmU6 EmMCOMBy68iOOKu7Q3Fxdb3WDcN5D3U2/H/ZqgoqNYZAmO90zGn3V7uFi 3eeUnVyPbLDwkgInKTbpulZ2cFI5hdBDb6ia8mD/cI5TlxyBvcJep1gRC 5QkepGDZCtw4Tjupi1VC0wdhSiq6EPPgU0GWyvIxhcWGz0bO3kn9K48tj mmji+EGKxGHzzM5311F+koMIxGyYQ78jOI1v7EWfuSuJi7LdLaToZHI2S rCDTMZxxGq+mTX01X29GXYbAL7rT4mgKY9ejAzHbPhcKdimXDaBecPayN w==; X-CSE-ConnectionGUID: X0ixOdF5Rj+8Wws3G/VQ8Q== X-CSE-MsgGUID: kNho4neAR3mdGwRXpj1v1g== X-IronPort-AV: E=McAfee;i="6700,10204,11365"; a="42446054" X-IronPort-AV: E=Sophos;i="6.14,226,1736841600"; d="scan'208";a="42446054" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2025 09:53:50 -0800 X-CSE-ConnectionGUID: lXk9vUeURSOFzz5QrvGS7w== X-CSE-MsgGUID: jvwBAumET9S2eHd1WBwZdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,226,1736841600"; d="scan'208";a="119278800" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2025 09:53:46 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tqFPi-00000000B5i-2edP; Thu, 06 Mar 2025 19:53:42 +0200 Date: Thu, 6 Mar 2025 19:53:42 +0200 From: Andy Shevchenko To: Vincent Mailhol Cc: Yury Norov , Lucas De Marchi , Rasmus Villemoes , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Andi Shyti , David Laight , Dmitry Baryshkov , Jani Nikula Subject: Re: [PATCH v5 2/7] bits: introduce fixed-type genmasks Message-ID: References: <20250306-fixed-type-genmasks-v5-0-b443e9dcba63@wanadoo.fr> <20250306-fixed-type-genmasks-v5-2-b443e9dcba63@wanadoo.fr> <1c081c07-2833-4fa9-96fb-88a7295d2c14@wanadoo.fr> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1c081c07-2833-4fa9-96fb-88a7295d2c14@wanadoo.fr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Mar 07, 2025 at 01:08:01AM +0900, Vincent Mailhol wrote: > On 06/03/2025 à 22:08, Andy Shevchenko wrote: > > On Thu, Mar 06, 2025 at 08:29:53PM +0900, Vincent Mailhol via B4 Relay wrote: ... > Does this mean I get your Reviewed-by tag? Or will you wait the v6 to > formally give it? I'll wait for v6. > > but just to be sure: you prepared your series using histogram > > diff algo, right? > > No, I never used the histogram diff. My git config is extremely boring. > Mostly vanilla. > > I remember that Linus even commented on this: > > https://lore.kernel.org/all/CAHk-=wiUxm-NZ1si8dXWVTTJ9n3c+1SRTC0V+Lk7hOE4bDVwJQ@mail.gmail.com/ > > But he made it clear this was *not* a requirement, so I just left the > diff algorithm to the default. Or did I miss any communication that > contributors should now use histogram diff? Use your common sense, i.e. look at the result and evaluate which one is more readable. My guts are telling me that histogram will be slightly better here. > Regardless, I do not mind activating it. I just did a: > > git config diff.algorithm histogram > > The v6 will have histogram diffs. -- With Best Regards, Andy Shevchenko