Re: [RFC PATCH v2 1/6] x86/sev: add SVSM call macros for the vTPM protocol

Borislav Petkov
2025-03-10T11:09:00Z

On Fri, Feb 28, 2025 at 06:07:15PM +0100, Stefano Garzarella wrote:
> Add macros for SVSM_VTPM_QUERY and SVSM_VTPM_CMD calls as defined
> in the "Secure VM Service Module for SEV-SNP Guests"
> Publication # 58019 Revision: 1.00
>
> Link: https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/specifications/58019.pdf

Those URLs are unstable - simply naming the document properly in the commit
message so that a search engine can find it is enough.

> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> arch/x86/include/asm/sev.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h
> index 1581246491b5..f6ebf4492606 100644
> --- a/arch/x86/include/asm/sev.h
> +++ b/arch/x86/include/asm/sev.h
> @@ -384,6 +384,10 @@ struct svsm_call {
> #define SVSM_ATTEST_SERVICES 0
> #define SVSM_ATTEST_SINGLE_SERVICE 1
>
> +#define SVSM_VTPM_CALL(x) ((2ULL << 32) | (x))
> +#define SVSM_VTPM_QUERY 0
> +#define SVSM_VTPM_CMD 1
> +
> #ifdef CONFIG_AMD_MEM_ENCRYPT
>
> extern u8 snp_vmpl;
> --

Merge this patch with the patch where those are used - no need for a separate
patch.

Thx.

--
Regards/Gruss,
Boris.