Re: [RFC PATCH v2 4/6] tpm: add interface to interact with devices based on TCG Simulator

Jarkko Sakkinen
2025-03-04T17:14:08Z

On Tue, Mar 04, 2025 at 04:23:51PM +0100, Stefano Garzarella wrote:
> > This commit got me lost tbh.
>
> Now I understand why you got lost, my bad!

No need for apologies, just merely reporting what I do or do not
understand with brutal honesty ;-)

> I checked further and these structures seem to be specific to the vTPM
> protocol defined by AMD SVSM specification and independent of TCG TPM
> (unless reusing some definitions like TPM_SEND_COMMAND).
>
> At this point I think it is best to remove this header (or move in x86/sev)
> and move this rewrap to x86/sev to avoid confusion.

Yeah, I do agree. We can commit to SVSM specification because that
is the target of this driver anyhow (not Microsoft simulator) :-)

>
> I'll do in v3, sorry for the confusion.

Absolutely, np.

>
> Stefano

BR, Jarkko