Re: [PATCH v4 01/11] perf dso: Move libunwind dso_data variables into ifdef

Arnaldo Carvalho de Melo
2025-03-05T17:52:59Z

On Mon, Mar 03, 2025 at 09:02:55PM -0800, Ian Rogers wrote:
> The variables elf_base_addr, debug_frame_offset, eh_frame_hdr_addr and
> eh_frame_hdr_offset are only accessed in unwind-libunwind-local.c
> which is conditionally built on having libunwind support. Make the
> variables conditional on libunwind support too.

Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>

> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/dso.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h
> index bb8e8f444054..dfd763a0bd9d 100644
> --- a/tools/perf/util/dso.h
> +++ b/tools/perf/util/dso.h
> @@ -154,10 +154,12 @@ struct dso_data {
> int status;
> u32 status_seen;
> u64 file_size;
> +#ifdef HAVE_LIBUNWIND_SUPPORT
> u64 elf_base_addr;
> u64 debug_frame_offset;
> u64 eh_frame_hdr_addr;
> u64 eh_frame_hdr_offset;
> +#endif
> };
>
> struct dso_bpf_prog {
> --
> 2.48.1.711.g2feabab25a-goog