Re: [PATCH v5 1/6] dt-bindings: iio: filter: Add lpf/hpf freq margins

Krzysztof Kozlowski
2025-03-07T08:34:27Z

On Thu, Mar 06, 2025 at 01:33:09PM -0500, Sam Winchenbach wrote:
> Adds two properties to add a margin when automatically finding the
> corner frequencies.
>
> Signed-off-by: Sam Winchenbach <sam.winchenbach@framepointer.org>
> ---
> .../bindings/iio/filter/adi,admv8818.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> index b77e855bd594..3f9c61547a78 100644
> --- a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> +++ b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> @@ -44,6 +44,27 @@ properties:
> '#clock-cells':
> const: 0
>
> +

Unnecessary blank line

> + adi,lpf-margin-hz:
> + description:
> + Sets the minimum distance (in Hz) between the fundamental
> + frequency of `rf_in` and the corner frequency of the low-pass, output
> + filter when operatred in 'auto' mode. The selected low-pass corner
> + frequency will be greater than, or equal to, `rf_in` + `lpf-margin-hz`. If
> + not setting is found that satisfies this relationship the filter will be
> + put into 'bypass'.
> + default: 0

hz are 32-bit, not 64-bit, so I think you need:

default: [0, 0]
minItems: 2
maxItems: 2

Best regards,
Krzysztof