From: Alice Ryhl <aliceryhl@google.com>
To: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Cc: a.hindborg@kernel.org, alex.gaynor@gmail.com, apw@canonical.com,
arnd@arndb.de, aswinunni01@gmail.com, axboe@kernel.dk,
benno.lossin@proton.me, bhelgaas@google.com,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com, dakr@kernel.org,
dwaipayanray1@gmail.com, ethan.twardy@gmail.com,
fujita.tomonori@gmail.com, gary@garyguo.net,
gregkh@linuxfoundation.org, joe@perches.com,
lukas.bulwahn@gmail.com, ojeda@kernel.org, pbonzini@redhat.com,
tmgross@umich.edu, walmeida@microsoft.com, charmitro@posteo.net,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: Re: [PATCH V7 1/2] rust: module: change author to an array
Date: Fri, 7 Mar 2025 13:26:14 +0000 [thread overview]
Message-ID: <Z8rz9nrY7Yj1Z2hP@google.com> (raw)
In-Reply-To: <20250307131401.638820-2-trintaeoitogc@gmail.com>
On Fri, Mar 07, 2025 at 10:14:00AM -0300, Guilherme Giacomo Simoes wrote:
> In the module! macro, the author field is currently of type String.
> Since modules can have multiple authors, this limitation prevents
> specifying more than one.
> Change the author field to Option<Vec<String>> to allow creating modules
> with multiple authors. Additionally, rename the field from author to
> authors to make it explicit that it can refer to multiple authors. In
> modules that use the author field, update its value to an array of
> strings, and also rename it from author to authors.
>
> Suggested-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> Link: https://github.com/Rust-for-Linux/linux/issues/244
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
I believe I reviewed this on the previous version. Did you forget to
pick up my tag, or did you change something in this patch that requires
a re-review?
Alice
next prev parent reply other threads:[~2025-03-07 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 13:13 [PATCH V7 0/2] author field in module! macro should be a array Guilherme Giacomo Simoes
2025-03-07 13:14 ` [PATCH V7 1/2] rust: module: change author to an array Guilherme Giacomo Simoes
2025-03-07 13:26 ` Alice Ryhl [this message]
2025-03-07 15:43 ` Guilherme Giacomo Simoes
2025-03-07 16:24 ` Miguel Ojeda
2025-03-08 0:40 ` Guilherme Giacomo Simoes
2025-03-09 21:03 ` Miguel Ojeda
2025-03-10 11:53 ` Guilherme Giacomo Simoes
2025-03-07 13:14 ` [PATCH V7 2/2] checkpatch: check format of Vec<String> in modules Guilherme Giacomo Simoes
2025-03-08 18:30 ` Daniel Sedlak
2025-03-09 17:47 ` Guilherme Giacomo Simoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8rz9nrY7Yj1Z2hP@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=aswinunni01@gmail.com \
--cc=axboe@kernel.dk \
--cc=benno.lossin@proton.me \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=charmitro@posteo.net \
--cc=dakr@kernel.org \
--cc=dwaipayanray1@gmail.com \
--cc=ethan.twardy@gmail.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=trintaeoitogc@gmail.com \
--cc=walmeida@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox