Re: [PATCH 2/2] vsprintf: remove redundant and unused %pCn format specifier

Luca Ceresoli
2025-03-10T11:24:12Z

Hello,

+To: Alex Shi, Yanteng Si (Chinese docs maintainers)
+Cc: Binbin Zhou (contributor to English version of printk-formats.rst)

On Mon, 10 Mar 2025 10:17:14 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Sat, Mar 08, 2025 at 12:34:25AM +0100, Luca Ceresoli wrote:
> > On Fri, 7 Mar 2025 19:17:26 +0200
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > On Fri, Mar 07, 2025 at 12:19:08PM +0100, Luca Ceresoli wrote:
> > > > %pC and %pCn print the same string, and commit 900cca294425 ("lib/vsprintf:
> > > > add %pC{,n,r} format specifiers for clocks") introducing them does not
> > > > clarify any intended difference. It can be assumed %pC is a default for
> > > > %pCn as some other specifiers do, but not all are consistent with this
> > > > policy. Moreover there is now no other suffix other than 'n', which makes a
> > > > default not really useful.
> > > >
> > > > All users in the kernel were using %pC except for one which has been
> > > > converted. So now remove %pCn and all the unnecessary extra code and
> > > > documentation.
> > >
> > > You seem forgot to update translation(s) of the documentation.
> >
> > I'm afraid I don't speak Chinese. :-)
>
> At bare minimum we can drop the same line in the list.
> Also in such a case we may ask a Chinese speaking person to review / correct /
> suggest the changes. I would not leave a leftover as it will be forgotten so
> easily and documentation becomes not in sync.

Alex Shi, Yanteng Si: what is the process to update the Chinese
documentation after changes to the English one, considering I don't
speak Chinese?

The documentation [0] seems to imply it will be done by you after the
English documentation update, is it the case?

Otherwise, for this simple change, I can add a patch that looks like a
somewhat correct one for Chinese:

@@ -523,9 +523,8 @@ clk结构体
::

%pC pll1
- %pCn pll1

-用于打印clk结构。%pC 和 %pCn 打印时钟的名称（通用时钟框架）或唯一的32位
+用于打印clk结构。%pC 打印时钟的名称（通用时钟框架）或唯一的32位
ID（传统时钟框架）。

通过引用传递。

Can you confirm the above is a correct change?

Luca

[0] https://docs.kernel.org/translations/index.html

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering