[PATCH v3 13/16] fsi: i2cr: Replace open-coded parity calculation with parity32()

Kuan-Wei Chiu
2025-03-06T16:28:07Z

Refactor parity calculations to use the standard parity32() helper.
This change eliminates redundant implementations and improves code
efficiency.

Co-developed-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
Changes in v3:
- Change parity ^= parity32(v) to parity != parity32(v).

drivers/fsi/fsi-master-i2cr.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c
index 40f1f4d231e5..46511236bbca 100644
--- a/drivers/fsi/fsi-master-i2cr.c
+++ b/drivers/fsi/fsi-master-i2cr.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/* Copyright (C) IBM Corporation 2023 */

+#include <linux/bitops.h>
#include <linux/device.h>
#include <linux/fsi.h>
#include <linux/i2c.h>
@@ -38,14 +39,7 @@ static const u8 i2cr_cfam[] = {

static bool i2cr_check_parity32(u32 v, bool parity)
{
- u32 i;
-
- for (i = 0; i < 32; ++i) {
- if (v & (1u << i))
- parity = !parity;
- }
-
- return parity;
+ return parity != parity32(v);
}

static bool i2cr_check_parity64(u64 v)
--
2.34.1