Re: [PATCH net-next v1 0/4] net: remove rtnl_lock from the callers of queue APIs

Stanislav Fomichev
2025-03-08T03:33:07Z

On 03/07, Jakub Kicinski wrote:
> On Fri, 7 Mar 2025 07:57:21 -0800 Stanislav Fomichev wrote:
> > All drivers that use queue management APIs already depend on the netdev
> > lock. Ultimately, we want to have most of the paths that work with
> > specific netdev to be rtnl_lock-free (ethtool mostly in particular).
> > Queue API currently has a much smaller API surface, so start with
> > rtnl_lock from it:
> >
> > - add mutex to each dmabuf binding (to replace rtnl_lock)
> > - protect global net_devmem_dmabuf_bindings with a new (global) lock
> > - move netdev lock management to the callers of netdev_rx_queue_restart
> > and drop rtnl_lock
>
> One more note, looks like this silently conflicts with my:
> https://lore.kernel.org/all/20250307183006.2312761-1-kuba@kernel.org/
>
> You need to add:
>
> #include <net/netdev_lock.h>
>
> to net/core/netdev_rx_queue.c, otherwise the series together break
> the build.

Noted, thanks!