From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DE2F14F9F9 for ; Sat, 8 Mar 2025 06:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741416240; cv=none; b=FrPPuVH2yk4qb/S5hhb4BhTqXWIEabbc3PQkdvBeSiSXWneQCaTEi3TpySbgKLVcVkUT3AhTRHcwfiJsa34HG2czOqN86wugKKnz160LLYUb+LUe3Vrnz8m1dzuhryHSkKatE4a+KdfOIcwIeVb6Gd6UqL88pEHmIGzzciEFl+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741416240; c=relaxed/simple; bh=UtKF8Vg/8ur3x9ZZufYsKRKBGlH122N5R3zj7Hw67+c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LfOJI9vArH6WoamMaMNjpftL25vKllESq/IqhGqKPVVVLXsQOLP9+6rW9SR0bfIZyP1nKBqv97nQICAG+365IfLHlEUmHbhW+KzyESQ4PoNjZ2P0y4Ak25OZ29sAjHbdeaXt4e8Q1KUSuxCjmRmfKn+z8IVsiwY8ZSQe/t5svwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=XVgz4JYP; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="XVgz4JYP" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-224019ad9edso63813535ad.1 for ; Fri, 07 Mar 2025 22:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1741416237; x=1742021037; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L7XYd6bILvV5S9oc7kfROdvIGE+piMUFy2TT1wDFAAs=; b=XVgz4JYPbICcYstIjrVqj42hOBnrp1eXLLfvNDdBC8iohlUs8vJlpZFFfy0v7Gk7hR uJV2w6kFuLuQHvLiRg73yX/FWNvclFt941gRoWvfOtKpP9wVSyi3vYjme8uGSUCTRbTh Id/K4ob38oUXP1yAjqFPAoM/nIbmkM1Wgpn9Xn3U/NzIZcUNiPuW9/nBuXJHRnvp1N18 4CoBETKcRJV+gN4jJ6zaeKkMsixI3KtURKfpbQ/8grjrm7LrjKNBBgbjILpdJnK2yuJp 7hAUDfVmsCRX/8XvxpIpy/Md2vp5bxSzNyEdsZxh1y33ZtUgsRQbLjlzRnLy7I5jMsEA 8RwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741416237; x=1742021037; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L7XYd6bILvV5S9oc7kfROdvIGE+piMUFy2TT1wDFAAs=; b=nnW5vaRM0ohGu8h9ehZIJAr12/ea0wgi9scb/I1LXSbfiYb3MmbroA/re+3WVDMmPy GnwaxMGQyH0jZJREAvz0roYo7TlsHWH+zW44Wiq1qYpgjzfLT+PjKyl2v/G+6XbXZPid HPg7AjBdMXqxFNJgR5HD6/jyU4fxFTzKFcclbp2RM2UIq/6161+M4q55cswrTW3+0meX 3ESGznhTwg1mV12WUkK8d6EYWBBMesqmSvmrqIetw/axEKPPPckps1xWAehK3sgsEQMU P0N9vTymRF9hLJRzSQMMxtQwKCEIJXKQ1ZZbCN2UVGuqugDiY6u+RTCUF4x8OCjGV5TM +bwA== X-Forwarded-Encrypted: i=1; AJvYcCVO++CMiM5mbPv5ISfGd3ofJGNQIMMj6JQYVtCqh3A8MZmADYVWB1bU0WPIjT1W+SiPWHsZ4kbOM5gWw5E=@vger.kernel.org X-Gm-Message-State: AOJu0YyiQe2BxY87prdKgYsZFg795hoTr1iu2OMMpjSo5MwdeYngPTGg M8j2r9VsQ1TvgROxn77/nkaO0KvZl+rHEgi6Ic2VmUQ8g1qeRQ8ISypZBMeq70U= X-Gm-Gg: ASbGncsC3zT5Q5fG3QlrIIKei3HEpkVx/6IqJjDfjGVo+qwHswTOWGHqAdl+Gctyd4a ZWeJaeH5Atc6cNcyVJKpPqf5VTW1G6YnHrBdAOJ3XgRGZ1xg9Y5nz6k4qif+D0UEyxa0N2cA37+ ntnOok/XHckcbQa8GK/80qsECDZoTztDTw1DoM3VFJzUJQPXT53/2AqA9Red/N5Eqb6/Jc4uVZV SxPN3s258JxpTMslnP/fr1lFHYYQoPjhjjFTtDH1Vda6IlJkOVCrffRTxDHIkbAki+qzQjPIJ+h aAAHQPpRYF3C2FGL0F5Wpkx1h+AX4mgGTtfJXFPjT9Znjb4VdphMxJu6iouEw/qwPFijwFB3itT luWU092HP7lJzx4rfrgmw X-Google-Smtp-Source: AGHT+IF/hoytkHf/78nzK/gEIzqXnGG5MP6Y8FgGhVp8Zx6LE+l7N0K13IdyKh5Omm9Q6AhxhqYyLg== X-Received: by 2002:a17:903:98b:b0:223:397f:46be with SMTP id d9443c01a7336-22428ad4a09mr106979815ad.47.1741416237682; Fri, 07 Mar 2025 22:43:57 -0800 (PST) Received: from dread.disaster.area (pa49-186-89-135.pa.vic.optusnet.com.au. [49.186.89.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-224109e816csm40661065ad.54.2025.03.07.22.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 22:43:57 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.98) (envelope-from ) id 1tqnuc-0000000ALct-08Dn; Sat, 08 Mar 2025 17:43:54 +1100 Date: Sat, 8 Mar 2025 17:43:53 +1100 From: Dave Chinner To: Yunsheng Lin Cc: Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Carlos Maiolino , "Darrick J. Wong" , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Luiz Capitulino , Mel Gorman , kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements Message-ID: References: <20250228094424.757465-1-linyunsheng@huawei.com> <91fcdfca-3e7b-417c-ab26-7d5e37853431@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91fcdfca-3e7b-417c-ab26-7d5e37853431@huawei.com> On Tue, Mar 04, 2025 at 08:09:35PM +0800, Yunsheng Lin wrote: > On 2025/3/4 16:18, Dave Chinner wrote: > > ... > > > > >> > >> 1. https://lore.kernel.org/all/bd8c2f5c-464d-44ab-b607-390a87ea4cd5@huawei.com/ > >> 2. https://lore.kernel.org/all/20250212092552.1779679-1-linyunsheng@huawei.com/ > >> CC: Jesper Dangaard Brouer > >> CC: Luiz Capitulino > >> CC: Mel Gorman > >> CC: Dave Chinner > >> CC: Chuck Lever > >> Signed-off-by: Yunsheng Lin > >> Acked-by: Jeff Layton > >> --- > >> V2: > >> 1. Drop RFC tag and rebased on latest linux-next. > >> 2. Fix a compile error for xfs. > > > > And you still haven't tested the code changes to XFS, because > > this patch is also broken. > > I tested XFS using the below cmd and testcase, testing seems > to be working fine, or am I missing something obvious here > as I am not realy familiar with fs subsystem yet: That's hardly what I'd call a test. It barely touches the filesystem at all, and it is not exercising memory allocation failure paths at all. Go look up fstests and use that to test the filesystem changes you are making. You can use that to test btrfs and NFS, too. -Dave. -- Dave Chinner david@fromorbit.com