From: Danilo Krummrich <dakr@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: bhelgaas@google.com, gregkh@linuxfoundation.org,
rafael@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com,
boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, a.hindborg@kernel.org,
aliceryhl@google.com, tmgross@umich.edu, llvm@lists.linux.dev,
oe-kbuild-all@lists.linux.dev, linux-pci@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] rust: pci: impl TryFrom<&Device> for &pci::Device
Date: Fri, 21 Mar 2025 18:44:22 +0100 [thread overview]
Message-ID: <Z92ldvI4ihlm0HJd@cassiopeiae> (raw)
In-Reply-To: <202503220040.TDePlxma-lkp@intel.com>
On Sat, Mar 22, 2025 at 12:56:58AM +0800, kernel test robot wrote:
> >> error[E0133]: use of extern static is unsafe and requires unsafe block
> --> rust/kernel/pci.rs:473:43
> |
> 473 | if dev.bus_type_raw() != addr_of!(bindings::pci_bus_type) {
> | ^^^^^^^^^^^^^^^^^^^^^^ use of extern static
> |
> = note: extern statics are not controlled by the Rust type system: invalid data, aliasing violations or data races will cause undefined behavior
This requires an unsafe block for compilers < 1.82. For compilers >= 1.82 it
turns into a warning *if* using an unsafe block.
*Not* requiring unsafe for this seems like the correct thing -- was this a
bugfix in the compiler?
I guess to make it work for all compiler versions supported by the kernel we
have to use unsafe and suppress the warning?
next prev parent reply other threads:[~2025-03-21 17:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 22:27 [PATCH v2 0/4] Implement TryFrom<&Device> for bus specific devices Danilo Krummrich
2025-03-20 22:27 ` [PATCH v2 1/4] rust: device: implement Device::parent() Danilo Krummrich
2025-03-20 22:44 ` Benno Lossin
2025-03-20 23:46 ` Danilo Krummrich
2025-03-21 1:40 ` Greg KH
2025-03-21 9:04 ` Danilo Krummrich
2025-03-21 13:03 ` Danilo Krummrich
2025-03-21 13:09 ` Greg KH
2025-03-21 14:16 ` Danilo Krummrich
2025-03-21 14:40 ` Boqun Feng
2025-03-21 14:46 ` Danilo Krummrich
2025-03-20 22:27 ` [PATCH v2 2/4] rust: device: implement bus_type_raw() Danilo Krummrich
2025-03-20 22:55 ` Benno Lossin
2025-03-20 22:27 ` [PATCH v2 3/4] rust: pci: impl TryFrom<&Device> for &pci::Device Danilo Krummrich
2025-03-20 23:44 ` Benno Lossin
2025-03-20 23:48 ` Danilo Krummrich
2025-03-21 16:56 ` kernel test robot
2025-03-21 17:44 ` Danilo Krummrich [this message]
2025-03-21 18:59 ` Miguel Ojeda
2025-03-21 19:11 ` Danilo Krummrich
2025-03-21 19:37 ` Miguel Ojeda
2025-03-22 10:08 ` Benno Lossin
2025-03-20 22:27 ` [PATCH v2 4/4] rust: platform: impl TryFrom<&Device> for &platform::Device Danilo Krummrich
2025-03-20 23:44 ` Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z92ldvI4ihlm0HJd@cassiopeiae \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox