Re: [PATCH] sched/fair: Add null pointer check to pick_next_entity()

Peter Zijlstra
2025-04-16T12:44:55Z

On Tue, Apr 15, 2025 at 10:02:35AM +0200, Peter Zijlstra wrote:
> On Mon, Apr 14, 2025 at 03:57:42PM -0400, Rik van Riel wrote:
> > On Wed, 2025-04-02 at 10:22 +0200, Peter Zijlstra wrote:
> > >
> > > Please confirm what the reason for overflow is.
> > >
> > Running a large enough sample size has its benefits.
> >
> > We have hit 3 out of the 4 warnings below.
> >
> > The only one we did not hit is the cfs_rq->avg_load != avg_load
> > warning.
>
> Fair enough, that one really isn't hard.
>
> > Most of the time we seem to hit the warnings from the
> > code that removes tasks from the runqueue,
>
> *blink*..

Which warning is getting hit on removal? The avg_vruntime mismatch?

Also, which removal path? schedule()'s block path, or migration like?