From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E830C22DFA5 for ; Tue, 11 Mar 2025 10:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741689513; cv=none; b=V5JmRCaOXq64P2FJA4rAuwPBsn/Mf2tLUgVaoTEsTjyE+SX7ORyIPw3At1LGPctgZQYJz7fNmIoPJZEkP4qccG6QcWYqptA1R+nH5hBe01+fgay7ycZ9QWKXfbR7LqKPTFL8HwWJM8+XYW9Ze0RcZbA6+x2BqDqYBLvBRLUQ4i8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741689513; c=relaxed/simple; bh=bZNmeeJGdW6e1FhGKC9CeGntVL96H/2KvoayCD+biY4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sCgIhD+/GOTjR8KYYAGIgKyoyqBRdiibJuK8yw9ovHHhAFu2AczrOInMCvJ3fz9Bw7EsbJ3v0i1SIzbSj8jRh0E/IpmsohRUp0AL4YEatF1+HcBBdxsXgzN71tRpmIl7QF3+YHdG5NVd3PqW9P2Ws9K6IdwxTwObsrE+Q3xZadY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=GTcgDXAw; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="GTcgDXAw" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-22185cddbffso110868605ad.1 for ; Tue, 11 Mar 2025 03:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1741689510; x=1742294310; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f1K76VH9GZtVs+LPd+wKDkO5SY/QeivVsM/htD74ZLE=; b=GTcgDXAwx/ARM9nEBghY5AJuHUStiwulWJF5XVFmWuYk0E/rHQW9hLgWUhWpBNE1Sg ewOZNfbb5BVRO2Nt8Tj9jnX2IlyrtX9ro9D2MgEnJ5VZM5Utt2nFmGU6I/s8O5HZWKMn D9p0k+uX2XkcC7bKXATp+jfmY9Akhzf694Pha5mPlB1BrlGtLdJ6t8AdZfhoRlLaKe7z 0Z+uZKYFAa9oGNzkK5tFx/UWQyKlbyzJPg81RANgi/ICE5ZxnJjdN9zEzX48W2PN3syj 74LxROofU8FrrXWdJiA8k0IpZsJrVVV7+FeLxyQxKXpc1obzstwQ3KbF1A3oVhPcoMGD 306g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741689510; x=1742294310; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f1K76VH9GZtVs+LPd+wKDkO5SY/QeivVsM/htD74ZLE=; b=qUnzAQizEiwx2MaDC15xArtWHfb+iMCTidX2Ol+U5jGiilVS62ipvtgFRlZKIg4uKL TDgOPH+81aMbVJ5YPUihday7zEA6EQ41err8ge/6uRi2HeIVishnnf8C8MajRllLqlE2 jfBkwuCQfEIICSHL01BTCo/q2OybM6efi17HAf7dd5R3kX101+vdR2mjq2IYinz6lcxh Iig+BfU2z9qHYs9eW2NtpjDYMZjr36q5tpY7wWV4HTxueyy2J5CFoRgD4ZeKH+X6sUEx W9YnwKbg8tRKvaDMIXeXnAxKunbkBOwqzlikHzCFUj4U/sj2ghycYq+xugEWjJi/LFFr hmoQ== X-Forwarded-Encrypted: i=1; AJvYcCVMP21DL696/dWMHrkwn1PHvd2LAIzUBH2xHS14FZzB+mAwzKw0eOUxLq9KAHDLXeIyZ+LrsR4JLA7EyfA=@vger.kernel.org X-Gm-Message-State: AOJu0YzQU8eDC26U9L2jfzx6rusrVfPty/36J/NoucX5i1LbLJcDsxX2 Jm9a/9mk91LK4wpKA9CP4Hzz3SxXO7WF3CB+fK7/s5WtfdD7VwvELQMKSUWhRPM= X-Gm-Gg: ASbGnct1k0v1BrcKAALZvf3jNnEos6jWYBAeeITfA4T+Bf99xAhltbdghS4/Fj0sZWN haKswMSSzZTWGGkWzXKBXE6/QxOu3jRL27p8cZxZVg1lsXRifQ8QUNSL8ryt1C51cAvNOaBmR1b UoDSmGsBHc0ZezWf7cNgynQtMVynQlaJa1vFCQGWuvlFbGNmXuHY9Q8gGprCpBkl9T359BQuN9w 2kqn13ozEH79EyEC/5sqWCS7dMeglj1jhMegDy9FUWXabmWrq/hgA9Z2JBFU8QHOjed/p2XrSdu Usz5UfS1Lmg5jp+Sghuu8yNm+/e6sDRbrZEvwQ66eK3erdbo/4vDpw== X-Google-Smtp-Source: AGHT+IGwF00pn0ttTAwXGotu4n032tAfHEPg1cyOkGTgN8LMC/JgxCYBqIV6RS/HysJzHJ7Xm/MRrw== X-Received: by 2002:a05:6a21:329f:b0:1f5:8cf7:de4b with SMTP id adf61e73a8af0-1f58d6ff812mr3970836637.16.1741689510077; Tue, 11 Mar 2025 03:38:30 -0700 (PDT) Received: from cyan-mbp ([136.226.240.168]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af287c2d533sm8673120a12.23.2025.03.11.03.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 03:38:29 -0700 (PDT) Date: Tue, 11 Mar 2025 18:38:25 +0800 From: Cyan Yang To: David Hildenbrand Cc: akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm/cow: Fix the incorrect error handling Message-ID: References: <20250311023730.56658-1-cyan.yang@sifive.com> <4a068856-328f-48ae-9b1c-0ec7d65dde6b@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a068856-328f-48ae-9b1c-0ec7d65dde6b@redhat.com> On Tue, Mar 11, 2025 at 10:19:32AM +0100, David Hildenbrand wrote: > On 11.03.25 03:37, Cyan Yang wrote: > > There are two error handlings did not check the correct return value. > > This patch will fix them. > > > > Fixes: f4b5fd6946e244cdedc3bbb9a1f24c8133b2077a ("selftests/vm: anon_cow: THP tests") > > Signed-off-by: Cyan Yang > > --- > > tools/testing/selftests/mm/cow.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c > > index 9446673645eb..16fcadc090a4 100644 > > --- a/tools/testing/selftests/mm/cow.c > > +++ b/tools/testing/selftests/mm/cow.c > > @@ -876,13 +876,13 @@ static void do_run_with_thp(test_fn fn, enum thp_run thp_run, size_t thpsize) > > mremap_size = thpsize / 2; > > mremap_mem = mmap(NULL, mremap_size, PROT_NONE, > > MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > > - if (mem == MAP_FAILED) { > > + if (mremap_mem == MAP_FAILED) { > > ksft_test_result_fail("mmap() failed\n"); > > goto munmap; > > } > > Yes, that check is wrong. > > > tmp = mremap(mem + mremap_size, mremap_size, mremap_size, > > MREMAP_MAYMOVE | MREMAP_FIXED, mremap_mem); > > - if (tmp != mremap_mem) { > > + if (tmp == MAP_FAILED) { > > ksft_test_result_fail("mremap() failed\n"); > > goto munmap; > > } > > As Dev says, this one is just fine. Leave it as it is. > Thank you for the review. I agree with you and Dev this is just fine. The reason I prefer to modify it is - usually caller checks the return value directly and "tmp == mremap_mem" should be determined by "mremap". If you still prefer to leave it as it is, I will send out the v2 to remove it. > -- > Cheers, > > David / dhildenb >