public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chao Gao <chao.gao@intel.com>
To: "Chang S. Bae" <chang.seok.bae@intel.com>
Cc: <tglx@linutronix.de>, <dave.hansen@intel.com>, <x86@kernel.org>,
	<seanjc@google.com>, <pbonzini@redhat.com>,
	<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
	<peterz@infradead.org>, <rick.p.edgecombe@intel.com>,
	<weijiang.yang@intel.com>, <john.allen@amd.com>, <bp@alien8.de>
Subject: Re: [PATCH v3 09/10] x86/fpu/xstate: Introduce XFEATURE_MASK_KERNEL_DYNAMIC xfeature set
Date: Tue, 11 Mar 2025 20:27:04 +0800	[thread overview]
Message-ID: <Z9AsGFF2Rs0lCC9/@intel.com> (raw)
In-Reply-To: <Z85+PPhKnkdN9pD6@intel.com>

On Mon, Mar 10, 2025 at 01:53:09PM +0800, Chao Gao wrote:
>On Sun, Mar 09, 2025 at 10:20:47PM -0700, Chang S. Bae wrote:
>>On 3/9/2025 8:49 PM, Chao Gao wrote:
>>> 
>>> It was suggested by Sean [1].
>>...
>>> [1]: https://lore.kernel.org/kvm/ZTf5wPKXuHBQk0AN@google.com/
>>
>>But, you're defining a kernel "dynamic" feature while introducing a
>>"guest-only" xfeature concept. Both seem to be mixed together with this
>>patch. Why not call it as a guest-only feature? That's what Sean was
>>suggesting, no?
>
>Yes. I agree that we should call it as a guest-only feature. That's also why I
>included a note in this patch below the "---" to seek feedback on the naming:
>
>	I am tempted to rename XFEATURE_MASK_KERNEL_DYNAMIC to
>	XFEATURE_MASK_GUEST_ONLY. But I am not sure if this was discussed
>	and rejected.
>
>Thanks for confirming that the renaming is necessary.

Hi Chang,

I dug through the history and found a discussion about the naming at:

https://lore.kernel.org/all/893ac578-baaf-4f4f-96ee-e012dfc073a8@intel.com/#t

I think I should revise the changelog to call out why 'DYNAMIC' is preferred
over 'GUEST' and reference that discussion.

  reply	other threads:[~2025-03-11 12:27 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 16:41 [PATCH v3 00/10] Introduce CET supervisor state support Chao Gao
2025-03-07 16:41 ` [PATCH v3 01/10] x86/fpu/xstate: Always preserve non-user xfeatures/flags in __state_perm Chao Gao
2025-03-07 16:41 ` [PATCH v3 02/10] x86/fpu/xstate: Drop @perm from guest pseudo FPU container Chao Gao
2025-03-07 16:41 ` [PATCH v3 03/10] x86/fpu/xstate: Correct xfeatures cache in guest pseudo fpu container Chao Gao
2025-03-07 17:48   ` Dave Hansen
2025-03-08  2:44     ` Chao Gao
2025-03-07 16:41 ` [PATCH v3 04/10] x86/fpu/xstate: Correct guest fpstate size calculation Chao Gao
2025-03-07 17:53   ` Dave Hansen
2025-03-08  2:56     ` Chao Gao
2025-03-07 21:37   ` Chang S. Bae
2025-03-08  2:49     ` Chao Gao
2025-03-09 22:06       ` Chang S. Bae
2025-03-10  1:33         ` Chao Gao
2025-03-10  5:21           ` Chang S. Bae
2025-03-10  7:06             ` Chao Gao
2025-03-10 17:33               ` Chang S. Bae
2025-03-11 12:09                 ` Chao Gao
2025-03-12  1:03                   ` Chang S. Bae
2025-03-07 16:41 ` [PATCH v3 05/10] x86/fpu/xstate: Introduce guest FPU configuration Chao Gao
2025-03-07 18:06   ` Dave Hansen
2025-03-08  3:00     ` Chao Gao
2025-03-07 16:41 ` [PATCH v3 06/10] x86/fpu/xstate: Initialize guest perm with fpu_guest_cfg Chao Gao
2025-03-07 18:14   ` Dave Hansen
2025-03-08  3:14     ` Chao Gao
2025-03-07 16:41 ` [PATCH v3 07/10] x86/fpu/xstate: Initialize guest fpstate with fpu_guest_config Chao Gao
2025-03-07 18:41   ` Dave Hansen
2025-03-08  3:38     ` Chao Gao
2025-03-07 16:41 ` [PATCH v3 08/10] x86/fpu/xstate: Add CET supervisor xfeature support Chao Gao
2025-03-07 18:39   ` Dave Hansen
2025-03-08  3:24     ` Chao Gao
2025-03-07 16:41 ` [PATCH v3 09/10] x86/fpu/xstate: Introduce XFEATURE_MASK_KERNEL_DYNAMIC xfeature set Chao Gao
2025-03-09 22:06   ` Chang S. Bae
2025-03-10  3:49     ` Chao Gao
2025-03-10  5:20       ` Chang S. Bae
2025-03-10  5:53         ` Chao Gao
2025-03-11 12:27           ` Chao Gao [this message]
2025-03-12  1:03             ` Chang S. Bae
2025-03-07 16:41 ` [PATCH v3 10/10] x86/fpu/xstate: Warn if CET supervisor state is detected in normal fpstate Chao Gao
2025-03-07 19:09 ` [PATCH v3 00/10] Introduce CET supervisor state support Dave Hansen
2025-03-18 15:24   ` Chao Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9AsGFF2Rs0lCC9/@intel.com \
    --to=chao.gao@intel.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=john.allen@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=weijiang.yang@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox