From: Keith Busch <kbusch@kernel.org>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmet: pci-epf: Remove redundant 'flush_workqueue()' calls
Date: Wed, 12 Mar 2025 11:57:48 -0600 [thread overview]
Message-ID: <Z9HLHHpdbDUgEhb2@kbusch-mbp> (raw)
In-Reply-To: <20250312085625.1624394-1-nichen@iscas.ac.cn>
On Wed, Mar 12, 2025 at 04:56:25PM +0800, Chen Ni wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
Thanks, applied to nvme-6.15.
prev parent reply other threads:[~2025-03-12 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 8:56 [PATCH] nvmet: pci-epf: Remove redundant 'flush_workqueue()' calls Chen Ni
2025-03-12 13:57 ` Christoph Hellwig
2025-03-12 17:43 ` Chaitanya Kulkarni
2025-03-12 17:57 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9HLHHpdbDUgEhb2@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nichen@iscas.ac.cn \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox