Re: [PATCH 4/5] x86/syscall/x32: Move x32 syscall table

Sohil Mehta
2025-03-14T16:02:34Z

On 3/14/2025 2:34 AM, Ingo Molnar wrote:
>
> * Sohil Mehta <sohil.mehta@intel.com> wrote:
>
>>> +#ifdef CONFIG_X86_X32_ABI
>>> +long x32_sys_call(const struct pt_regs *regs, unsigned int nr)
>>> +{
>>> + switch (nr) {
>>> + #include <asm/syscalls_x32.h>
>>> + default: return __x64_sys_ni_syscall(regs);
>>> + }
>>> +};
>>
>> There seems to be a stray semicolon here. The original code also has it
>> but it doesn't seem necessary.
>
> BTW., seeing that you've gone through this series with a fine comb I've
> added your Reviewed-by tag to the series (with the caveat that the
> details you've pointed out will be addressed in followup patches).
> Let me know if that's not OK.
>

Thanks, that would have been fine with me. Reviewing the v2 series now.

> Thanks,
>
> Ingo
>