Re: [PATCH 2/5] x86/syscall/32: Move 32-bit syscall dispatch code

Ingo Molnar
2025-03-14T09:27:37Z

* Brian Gerst <brgerst@gmail.com> wrote:

> On Thu, Mar 13, 2025 at 7:45 PM Sohil Mehta <sohil.mehta@intel.com> wrote:
> >
> > On 3/13/2025 11:22 AM, Brian Gerst wrote:
> >
> > > SYSCALL_DEFINE0(ni_syscall)
> > > {
> > > return -ENOSYS;
> > > diff --git a/arch/x86/entry/syscall_32.c b/arch/x86/entry/syscall_32.c
> > > index 8cc9950d7104..7c286e89fd04 100644
> > > --- a/arch/x86/entry/syscall_32.c
> > > +++ b/arch/x86/entry/syscall_32.c
> > > @@ -1,10 +1,23 @@
> > > -// SPDX-License-Identifier: GPL-2.0
> > > -/* System call table for i386. */
> > > +// SPDX-License-Identifier: GPL-2.0-only
> > > +/*
> > > + * 32-bit system call dispatch
> > > + *
> > > + * Copyright (c) 2015 Andrew Lutomirski
> > > + *
> > > + * Based on asm and ptrace code by many authors. The code here originated
> > > + * in ptrace.c and signal.c.
> >
> > Wondering if we can skip copying over some of these old comments? As the
> > file grows, it's hard to discerne what specific code originated where.
> > For example, the FRED code is all new.
>
> I wasn't sure what the appropriate thing would be so I just copied it
> over. The git history is probably a better way to attribute this
> though.

I suppose we could trim some of the old comments in followup patches,
as they'll be preserved in the Git log and often aren't really accurate
or particularly informative in the current code context.

Thanks,

Ingo