Re: [PATCH v3 3/8] perf sched stats: Add schedstat v17 support

Sapkal, Swapnil
2025-03-17T13:32:21Z

Hello Namhyung,

On 3/15/2025 7:57 AM, Namhyung Kim wrote:
> On Tue, Mar 11, 2025 at 12:02:25PM +0000, Swapnil Sapkal wrote:
>> /proc/schedstat file output is standardized with version number.
>> Add support to record and raw dump v17 version layout.
>>
>> Co-developed-by: Ravi Bangoria <ravi.bangoria@amd.com>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>> Signed-off-by: Swapnil Sapkal <swapnil.sapkal@amd.com>
>> ---
>> tools/lib/perf/Makefile | 2 +-
>> tools/lib/perf/include/perf/event.h | 14 +++++
>> tools/lib/perf/include/perf/schedstat-v17.h | 61 +++++++++++++++++++++
>> tools/perf/util/event.c | 6 ++
>> tools/perf/util/synthetic-events.c | 15 +++++
>> 5 files changed, 97 insertions(+), 1 deletion(-)
>> create mode 100644 tools/lib/perf/include/perf/schedstat-v17.h
>>
>> diff --git a/tools/lib/perf/Makefile b/tools/lib/perf/Makefile
>> index d0506a13a97f..30712ce8b6b1 100644
>> --- a/tools/lib/perf/Makefile
>> +++ b/tools/lib/perf/Makefile
>> @@ -174,7 +174,7 @@ install_lib: libs
>> $(call do_install_mkdir,$(libdir_SQ)); \
>> cp -fpR $(LIBPERF_ALL) $(DESTDIR)$(libdir_SQ)
>>
>> -HDRS := bpf_perf.h core.h cpumap.h threadmap.h evlist.h evsel.h event.h mmap.h schedstat-v15.h schedstat-v16.h
>> +HDRS := bpf_perf.h core.h cpumap.h threadmap.h evlist.h evsel.h event.h mmap.h schedstat-v15.h schedstat-v16.h schedstat-v17.h
>
> Please put them in a separate line like
>
> HDRS += schedstat-v15.h schedstat-v16.h schedstat-v17.h
>

Sure, Will change accordingly.

> Thanks,
> Namhyung
>

--
Thanks and Regards,
Swapnil