Re: [net-next,v3,2/2] net: phy: realtek: Add support for PHY LEDs on RTL8211E

Russell King (Oracle)
2025-03-17T17:26:18Z

Hi,

On Mon, Mar 17, 2025 at 06:23:07PM +0100, Michael Klein wrote:
> I don't think this needs to be atomic at all, as the phydev lock is held by
> the one and only caller (phy_led_hw_control_get()).
>
> rtl8211f_led_hw_control_get() also uses set_bit(). Should I change those
> also to __set_bit() in a separate patch while I'm at it?

Yes please.

Thanks!

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!