Re: [PATCH bpf-next] bpf: Define bpf_token_show_fdinfo with CONFIG_PROC_FS

Alexei Starovoitov
2025-03-18T14:59:41Z

On Tue, Mar 18, 2025 at 2:29 AM Jiri Olsa <olsajiri@gmail.com> wrote:
>
> On Tue, Mar 18, 2025 at 02:25:57PM +0800, Tao Chen wrote:
> > Protect bpf_token_show_fdinfo with CONFIG_PROC_FS check, follow the
> > pattern used with other *_show_fdinfo functions.
> >
> > Fixes: 35f96de04127 ("bpf: Introduce BPF token object")
> > Signed-off-by: Tao Chen <chen.dylane@linux.dev>
> > ---
> > kernel/bpf/token.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/kernel/bpf/token.c b/kernel/bpf/token.c
> > index 26057aa13..104ca37e9 100644
> > --- a/kernel/bpf/token.c
> > +++ b/kernel/bpf/token.c
> > @@ -65,6 +65,7 @@ static int bpf_token_release(struct inode *inode, struct file *filp)
> > return 0;
> > }
> >
> > +#ifdef CONFIG_PROC_FS
> > static void bpf_token_show_fdinfo(struct seq_file *m, struct file *filp)
> > {
> > struct bpf_token *token = filp->private_data;
> > @@ -98,6 +99,7 @@ static void bpf_token_show_fdinfo(struct seq_file *m, struct file *filp)
> > else
> > seq_printf(m, "allowed_attachs:\t0x%llx\n", token->allowed_attachs);
> > }
> > +#endif
> >
> > #define BPF_TOKEN_INODE_NAME "bpf-token"
> >
> > @@ -105,7 +107,9 @@ static const struct inode_operations bpf_token_iops = { };
> >
> > static const struct file_operations bpf_token_fops = {
> > .release = bpf_token_release,
> > +#ifdef CONFIG_PROC_FS
> > .show_fdinfo = bpf_token_show_fdinfo,
> > +#endif
>
> there's many more of such cases.. I'm not sure if it makes sense to fix that,
> because it does not break the build and only save space for !CONFIG_PROC_FS
> kernels

+1.
let's keep the code as-is.

pw-bot: cr