From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CC6A1C3BE2 for ; Tue, 18 Mar 2025 07:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742284706; cv=none; b=mc+Gth05CDvoDhnPayv/J8NfPP0o3ZEc+/J+s0+1QxrpBOvgLUix2XdtVzbesItAtOWdHNHC/Qc7jjh7r90So+ppKGj3NQG22CIgIVXY3XcHYOwCgCvNz496MxWiKmAtDWtyTZxvo79i/mfjH106GD2GhIE6LHHVLjZ4Q5Tjp6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742284706; c=relaxed/simple; bh=al49eM+1tgW5ACzH7lMAhrHbpJE/ZKJWrX8DKNsNMbg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d4LANlKsWIKtjNVAznHhF+CDJtXvlJABxmwaK+QaOWTfyY50q7jK2s7iaM+sOym47/ET4e29oAoZuC7zBJ3hSnG8dArW9gRZr/fVPqjEvGxKg2uVTSxFZMhEDrgYQSSXl4rRg/GYGksVqS57AQgs/eNxXvei0PpYnWOYkaNmvbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=furiosa.ai; spf=none smtp.mailfrom=furiosa.ai; dkim=pass (1024-bit key) header.d=furiosa.ai header.i=@furiosa.ai header.b=k1kq3hUL; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=furiosa.ai header.i=@furiosa.ai header.b="k1kq3hUL" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-22359001f1aso53694715ad.3 for ; Tue, 18 Mar 2025 00:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=furiosa.ai; s=google; t=1742284704; x=1742889504; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JjqSNVE0Cph4A/90eA+y7Se4Hin9uKNNKIYlFXcRpQc=; b=k1kq3hULFaIoP60zLinyPlm/oWo3dzLfE6C/8xathyU6CcfVrKNNf72Z4uGsMSV3un IGt3+dLehqa64pOQym5tZIbF3jNhvBUH3jfrAemiyfFa+bYlDuS1F/8jLMYg2MlEmo44 y+AwC5WMR5BmSw6/XcqJtnAH1RblIEvmWx3mc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742284704; x=1742889504; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JjqSNVE0Cph4A/90eA+y7Se4Hin9uKNNKIYlFXcRpQc=; b=aEdurfctLjVJJzjdG+SrYkgLVlTqCc77n4Kt4L99AIg0Mo7KmHp0ihkXAy5FgKIdP0 DNLiTWHuejaJ4gQ3zfQLRoDMVVa0uzOCLcS2CNlgGbpPUfGfu1vn2ewTttX5+QvW62lX OcACLUrxb8EfxFqwSNXLLO2JQhDw83b7/j5uJ6tYXv0XghsDcc23wav1zsdvhwtLRdzo bgNFxYMQ65XWIP7ycBRzAyoVHX7qRtNcXbdvpflghCuSPBjB2Nrirlgwe92O6IAfOZm6 r4sJMFl9OGQPQteWg3VVfWpIEcp5cH8p7iqjDtCzaX8pw8Q51ryJB+fnXfoprR+Zna4k jH+Q== X-Forwarded-Encrypted: i=1; AJvYcCXIsS1O/Unx8Y0mPu0/qnYuuHJfAkB9vmY5PoLkjeqNBSNDTDtQ/5x7O1Cb0JbXns0i3tizuYQx8Vio82o=@vger.kernel.org X-Gm-Message-State: AOJu0YyCU33LdNqbgk+WcSmk25W5d/JERgr1PiUb6gjQrOTXDZvMn+QZ srfEsIRxNTCxQxYT5MTWHEjSJbhJKOVWXyYfM9ZMRTbOf/nTyYbeHt6vmFJ1S/k= X-Gm-Gg: ASbGncumN4VmSWQUiMBYh5kuMGAmu/p6QB4XVClUwlwxSthva1zxB3JLyuOEPQj/MpB xxEbIzb2otPlBAk5S3N9bCwXLY1xyCHfhppQdey55dhUFQK+dCtrdEP1NyWbqwGp/JkqI+Jajq0 6DhjcCFxNPkHwP+Zty4oF+YWS1QJ23P3P58NO+W9eItNlt0qARedA+8+iSb4/H7s6m5Y/Z4fH2k 47416lSgE35V1TSgeGgy/by4ZryGtpDzs4WAJX/ipKBC2LsTWYQp3uU4mo8dSQeFhpR8z3BL6p6 P/ESgOwera2aDMyU44DNqxkHxmWYCvsWmbaxZEtfC3utOmeGjfpj1P0MO6YwMcSmmMO04ZpSDqi P X-Google-Smtp-Source: AGHT+IFoYIbKKLN/4JYODjVS6d9sUEzicBL53lbs5mcV9y8CEd9goF6jVujShbqHMNdGwaaPjoahMQ== X-Received: by 2002:a17:902:f711:b0:224:b60:3ce0 with SMTP id d9443c01a7336-2262c515130mr30785105ad.5.1742284704551; Tue, 18 Mar 2025 00:58:24 -0700 (PDT) Received: from sidongui-MacBookPro.local ([221.148.76.1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6889eeesm88219725ad.29.2025.03.18.00.58.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 00:58:24 -0700 (PDT) Date: Tue, 18 Mar 2025 16:58:20 +0900 From: Sidong Yang To: Pavel Begunkov Cc: Josef Bacik , David Sterba , Jens Axboe , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, Mark Harmstone Subject: Re: [RFC PATCH v4 5/5] btrfs: ioctl: don't free iov when -EAGAIN in uring encoded read Message-ID: References: <20250317135742.4331-1-sidong.yang@furiosa.ai> <20250317135742.4331-6-sidong.yang@furiosa.ai> <849ce82d-d87a-428a-be79-abdeb53a1a99@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <849ce82d-d87a-428a-be79-abdeb53a1a99@gmail.com> On Tue, Mar 18, 2025 at 07:21:00AM +0000, Pavel Begunkov wrote: > On 3/17/25 13:57, Sidong Yang wrote: > > This patch fixes a bug on encoded_read. In btrfs_uring_encoded_read(), > > btrfs_encoded_read could return -EAGAIN when receiving requests concurrently. > > And data->iov goes to out_free and it freed and return -EAGAIN. io-uring > > subsystem would call it again and it doesn't reset data. And data->iov > > freed and iov_iter reference it. iov_iter would be used in > > btrfs_uring_read_finished() and could be raise memory bug. > > Fixes should go first. Please send it separately, and CC Mark. > A "Fixes" tag would also be good to have. Okay, I'll remove this from patch series. Thanks, Sidong > > > Signed-off-by: Sidong Yang > > --- > > fs/btrfs/ioctl.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c > > index a7b52fd99059..02fa8dd1a3ce 100644 > > --- a/fs/btrfs/ioctl.c > > +++ b/fs/btrfs/ioctl.c > > @@ -4922,6 +4922,9 @@ static int btrfs_uring_encoded_read(struct io_uring_cmd *cmd, unsigned int issue > > ret = btrfs_encoded_read(&kiocb, &data->iter, &data->args, &cached_state, > > &disk_bytenr, &disk_io_size); > > + > > + if (ret == -EAGAIN) > > + goto out_acct; > > if (ret < 0 && ret != -EIOCBQUEUED) > > goto out_free; > > -- > Pavel Begunkov >