From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: giometti@enneenne.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] pps: generators: tio: fix platform_set_drvdata()
Date: Tue, 18 Mar 2025 15:43:46 +0200 [thread overview]
Message-ID: <Z9l4ktWrZ3VGN8B_@smile.fi.intel.com> (raw)
In-Reply-To: <20250318114038.2058677-1-raag.jadav@intel.com>
On Tue, Mar 18, 2025 at 05:10:38PM +0530, Raag Jadav wrote:
> platform_set_drvdata() is setting a double pointer to struct pps_tio as
> driver_data, which will point to the local stack of probe function instead
> of intended data. Set driver_data correctly and fix illegal memory access
> by its user.
>
> BUG: unable to handle page fault for address: ffffc9000117b738
> RIP: 0010:hrtimer_active+0x2b/0x60
> Call Trace:
> ? hrtimer_active+0x2b/0x60
> hrtimer_cancel+0x19/0x50
> pps_gen_tio_remove+0x1e/0x80 [pps_gen_tio]
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-18 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 11:40 [PATCH v3] pps: generators: tio: fix platform_set_drvdata() Raag Jadav
2025-03-18 13:43 ` Andy Shevchenko [this message]
2025-04-07 7:48 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9l4ktWrZ3VGN8B_@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox